Add foundation CrUXManager tests

crrev.com/c/7405594 + foundation tests for CrUXManager.

Bug: 446630695
Change-Id: If4805d8d31a3d5f9aeb8257bbf07c096a866f012
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7421201
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>

Author: OrKoN

front_end/BUILD.gn

@@ -132,7 +132,6 @@ group("unittests") {
     "models/bindings:unittests",
     "models/breakpoints:unittests",
     "models/cpu_profile:unittests",
-    "models/crux-manager:unittests",
     "models/emulation:unittests",
     "models/extensions:unittests",
     "models/geometry:unittests",
@@ -282,6 +281,7 @@ group("foundation_unittests") {
     "entrypoints/formatter_worker:unittests",
     "foundation:unittests",
     "models/ai_assistance:foundation_unittests",
+    "models/crux-manager:foundation_unittests",
     "models/formatter:unittests",
     "models/issues_manager:foundation_unittests",
   ]

front_end/core/host/InspectorFrontendHostStub.ts

@@ -147,6 +147,9 @@ export class InspectorFrontendHostStub implements InspectorFrontendHostAPI {
   }
 
   inspectedURLChanged(url: Platform.DevToolsPath.UrlString): void {
+    if (!('document' in globalThis)) {
+      return;
+    }
     document.title = i18nString(UIStrings.devtoolsS, {PH1: url.replace(/^https?:\/\//, '')});
   }
 

front_end/models/crux-manager/BUILD.gn

@@ -25,13 +25,14 @@ devtools_entrypoint("bundle") {
 
   visibility = [
     ":*",
+    "../../../mcp/*",
     "../../entrypoints/main",
     "../../panels/timeline/*",
     "../trace/*",
   ]
 }
 
-ts_library("unittests") {
+devtools_foundation_module("foundation_unittests") {
   testonly = true
 
   sources = [ "CrUXManager.test.ts" ]

front_end/models/crux-manager/CrUXManager.test.ts

@@ -7,14 +7,17 @@ import * as Platform from '../../core/platform/platform.js';
 import * as SDK from '../../core/sdk/sdk.js';
 import * as EmulationModel from '../../models/emulation/emulation.js';
 import {createTarget, updateHostConfig} from '../../testing/EnvironmentHelpers.js';
-import {describeWithMockConnection} from '../../testing/MockConnection.js';
+import {setupLocaleHooks} from '../../testing/LocaleHelpers.js';
+import {setupRuntimeHooks} from '../../testing/RuntimeHelpers.js';
+import {setupSettingsHooks} from '../../testing/SettingsHelpers.js';
 
 import * as CrUXManager from './crux-manager.js';
 
 const {urlString} = Platform.DevToolsPath;
 
-function mockResponse(scopes: {pageScope: CrUXManager.PageScope, deviceScope: CrUXManager.DeviceScope}|null = null):
-    CrUXManager.CrUXResponse {
+export function mockResponse(
+    scopes: {pageScope: CrUXManager.PageScope, deviceScope: CrUXManager.DeviceScope}|null =
+        null): CrUXManager.CrUXResponse {
   return {
     record: {
       key: {},
@@ -52,28 +55,34 @@ async function triggerMicroTaskQueue(): Promise<void> {
   await new Promise(resolve => setTimeout(resolve, 0));
 }
 
-describeWithMockConnection('CrUXManager', () => {
+describe('CrUXManager', () => {
   let cruxManager: CrUXManager.CrUXManager;
   let target: SDK.Target.Target;
   let resourceTreeModel: SDK.ResourceTreeModel.ResourceTreeModel;
   let mockFetch: sinon.SinonStub;
   let mockConsoleError: sinon.SinonStub;
 
+  setupRuntimeHooks();
+  setupSettingsHooks();
+  setupLocaleHooks();
+
   beforeEach(async () => {
+    SDK.TargetManager.TargetManager.instance({forceNew: true});
     const tabTarget = createTarget({type: SDK.Target.Type.TAB});
     target = createTarget({parentTarget: tabTarget});
+    target.setInspectedURL(urlString`https://example.com/inspected`);
     resourceTreeModel =
         target.model(SDK.ResourceTreeModel.ResourceTreeModel) as SDK.ResourceTreeModel.ResourceTreeModel;
     cruxManager = CrUXManager.CrUXManager.instance({forceNew: true});
-    mockFetch = sinon.stub(window, 'fetch');
+    mockFetch = sinon.stub(globalThis, 'fetch');
     mockConsoleError = sinon.stub(console, 'error');
     EmulationModel.DeviceModeModel.DeviceModeModel.instance({forceNew: true});
   });
 
   afterEach(() => {
-    mockFetch.restore();
-    mockConsoleError.restore();
-    cruxManager.getConfigSetting().set({enabled: false});
+    mockFetch?.restore();
+    mockConsoleError?.restore();
+    cruxManager?.getConfigSetting().set({enabled: false});
   });
 
   describe('storing the user consent', () => {

front_end/models/emulation/DeviceModeModel.ts

@@ -122,7 +122,7 @@ export class DeviceModeModel extends Common.ObjectWrapper.ObjectWrapper<EventTyp
     this.#preferredSize = new Geometry.Size(1, 1);
     this.#initialized = false;
     this.#appliedDeviceSize = new Geometry.Size(1, 1);
-    this.#appliedDeviceScaleFactor = window.devicePixelRatio;
+    this.#appliedDeviceScaleFactor = globalThis.devicePixelRatio;
     this.#appliedUserAgentType = UA.DESKTOP;
 
     this.#scaleSetting = Common.Settings.Settings.instance().createSetting('emulation.device-scale', 1);

mcp/BUILD.gn

@@ -21,6 +21,7 @@ devtools_module("mcp") {
     "../front_end/foundation:bundle",
     "../front_end/models/ai_assistance",
     "../front_end/models/bindings:bundle",
+    "../front_end/models/crux-manager:bundle",
     "../front_end/models/issues_manager:bundle",
     "../front_end/models/stack_trace:bundle",
     "../front_end/models/trace:bundle",

mcp/mcp.ts

@@ -34,6 +34,7 @@ export {
 } from '../front_end/models/ai_assistance/data_formatters/PerformanceTraceFormatter.js';
 export {AgentFocus} from '../front_end/models/ai_assistance/performance/AIContext.js';
 export {DebuggerWorkspaceBinding} from '../front_end/models/bindings/DebuggerWorkspaceBinding.js';
+export {CrUXManager} from '../front_end/models/crux-manager/CrUXManager.js';
 export {Issue} from '../front_end/models/issues_manager/Issue.js';
 export {
   AggregatedIssue,