Merge pull request #1076 from justinpbarnett/fix/manage-script-local-function-duplicates

Fix create_script validator false-positive inside method bodies

Author: Scriptwonder

MCPForUnity/Editor/Tools/ManageScript.cs

@@ -2714,12 +2714,18 @@ private static void CheckDuplicateMethodSignatures(string contents, System.Colle
             }
             // Second pass: build per-position containing type array
             var containingTypeArr = new string[codeOnly.Length];
+            var braceDepthArr = new int[codeOnly.Length];
+            var typeMemberDepthArr = new int[codeOnly.Length];
             {
                 var stack = new System.Collections.Generic.List<(string name, int openDepth)>();
                 int bd2 = 0;
                 string current = "";
                 for (int i = 0; i < codeOnly.Length; i++)
                 {
+                    containingTypeArr[i] = current;
+                    braceDepthArr[i] = bd2;
+                    typeMemberDepthArr[i] = stack.Count > 0 ? stack[stack.Count - 1].openDepth + 1 : -1;
+
                     if (codeOnly[i] == '{')
                     {
                         if (typeBraceMap.TryGetValue(i, out string tn))
@@ -2738,7 +2744,6 @@ private static void CheckDuplicateMethodSignatures(string contents, System.Colle
                             current = stack.Count > 0 ? stack[stack.Count - 1].name : "";
                         }
                     }
-                    containingTypeArr[i] = current;
                 }
             }
 
@@ -2757,6 +2762,8 @@ private static void CheckDuplicateMethodSignatures(string contents, System.Colle
                 int paramCount = CountTopLevelParams(sm.Groups[3].Value);
                 string paramTypes = ExtractParamTypes(sm.Groups[3].Value);
                 string containingType = containingTypeArr[sm.Index];
+                if (string.IsNullOrEmpty(containingType)) continue;
+                if (braceDepthArr[sm.Index] != typeMemberDepthArr[sm.Index]) continue;
                 string key = $"{containingType}/{methodName}/{paramCount}/{paramTypes}";
                 if (seen.TryGetValue(key, out _))
                     errors.Add($"ERROR: Duplicate method signature detected: '{methodName}' with {paramCount} parameter(s). This may indicate a corrupted edit.");

TestProjects/UnityMCPTests/Assets/Tests/EditMode/Tools/ManageScriptValidationTests.cs

@@ -378,6 +378,52 @@ void Start()
                 "new modifier on method should not interfere with constructor invocation filtering");
         }
 
+        [Test]
+        public void DuplicateMethodCheck_LocalFunctionsInDifferentMethods_NotFlagged()
+        {
+            string code = @"using UnityEngine;
+public class Test : MonoBehaviour
+{
+    void Start()
+    {
+        int ClampScore(int value) { return Mathf.Clamp(value, 0, 100); }
+        Debug.Log(ClampScore(10));
+    }
+
+    void Reset()
+    {
+        int ClampScore(int value) { return Mathf.Clamp(value, 0, 100); }
+        Debug.Log(ClampScore(0));
+    }
+}";
+            var errors = CallValidateScriptSyntaxUnity(code);
+            Assert.IsFalse(HasDuplicateMethodError(errors),
+                "Same-signature local functions in different methods are valid C# and should not be flagged as duplicate class methods");
+        }
+
+        [Test]
+        public void DuplicateMethodCheck_RepeatedMethodInvocations_NotFlagged()
+        {
+            string code = @"using UnityEngine;
+public class Test : MonoBehaviour
+{
+    int First()
+    {
+        return Compute();
+    }
+
+    int Second()
+    {
+        return Compute();
+    }
+
+    int Compute() { return 1; }
+}";
+            var errors = CallValidateScriptSyntaxUnity(code);
+            Assert.IsFalse(HasDuplicateMethodError(errors),
+                "Repeated method invocations inside method bodies should not be treated as duplicate method declarations");
+        }
+
         [Test]
         public void HandleCommand_PathWithCsExtension_StripsFilename()
         {