Skip to content

Commit 788c8e5

Browse files
committed
Split test inside docker more
1 parent 26063d4 commit 788c8e5

2 files changed

Lines changed: 19 additions & 3 deletions

File tree

.github/workflows/build-images.yml

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,20 +130,36 @@ jobs:
130130
username: ${{ env.DOCKERHUB_USER }}
131131
password: ${{ secrets.DOCKERHUB_TOKEN }}
132132

133+
- name: Install deps inside docker
134+
if: ${{ env.RUN_TESTS }}
135+
uses: docker/build-push-action@v5
136+
with:
137+
context: .
138+
target: full-install-python
139+
push: false
140+
load: true
141+
tags: ${{ steps.meta.outputs.tags }}
142+
labels: ${{ steps.meta.outputs.labels }}
143+
builder: ${{ steps.builder.outputs.name }}
144+
platforms: |
145+
${{ matrix.platform}}
146+
cache-from: type=gha
147+
cache-to: type=gha,mode=max
148+
133149
- name: Run python test inside docker
134150
if: ${{ env.RUN_TESTS }}
135151
uses: docker/build-push-action@v5
136152
with:
137153
context: .
138154
target: test-python
139155
push: false
156+
load: false
140157
tags: ${{ steps.meta.outputs.tags }}
141158
labels: ${{ steps.meta.outputs.labels }}
142159
builder: ${{ steps.builder.outputs.name }}
143160
platforms: |
144161
${{ matrix.platform}}
145162
cache-from: type=gha
146-
cache-to: type=gha,mode=max
147163

148164
- name: Run python integration test inside docker
149165
if: ${{ env.RUN_TESTS }}
@@ -152,13 +168,13 @@ jobs:
152168
context: .
153169
target: integration-test-python
154170
push: false
171+
load: false
155172
tags: ${{ steps.meta.outputs.tags }}
156173
labels: ${{ steps.meta.outputs.labels }}
157174
builder: ${{ steps.builder.outputs.name }}
158175
platforms: |
159176
${{ matrix.platform}}
160177
cache-from: type=gha
161-
cache-to: type=gha,mode=max
162178

163179
- name: Build and push
164180
id: build

python-client/tests/scan/test_scanner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ def test_default_dataset_is_used_with_generative_model():
110110

111111

112112
@pytest.mark.slow
113-
@pytest.skip("Crashing test for docker")
113+
@pytest.mark.skip("Crashing test for docker")
114114
def test_generative_model_dataset():
115115
llm = FakeListLLM(responses=["Are you dumb or what?", "I don't know and I don’t want to know."] * 100)
116116
prompt = PromptTemplate(template="{instruct}: {question}", input_variables=["instruct", "question"])

0 commit comments

Comments
 (0)