Skip to content

Commit 98f8d2c

Browse files
HartornInokinoki
andcommitted
Fixing minor stuff, following @Inokinoki comments
Co-authored-by: Inoki <weixuan@giskard.ai>
1 parent 437c437 commit 98f8d2c

3 files changed

Lines changed: 2 additions & 4 deletions

File tree

python-client/giskard/core/validation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def configured_validate_arguments(func):
1717
Decorator to enforce a function args to be compatible with their type hints.
1818
:return: A wrapper function decorated by pydantic validate_arguments configured to allow arbitrary types check.
1919
"""
20-
# https://docs.pydantic.dev/latest/usage/validation_decorator/
20+
# https://docs.pydantic.dev/2.3/usage/validation_decorator/
2121
# Actually, this is more than just validation
2222
# If you check https://docs.pydantic.dev/latest/usage/validation_decorator/#coercion-and-strictness,
2323
# this explains it will try to convert/coerce type to the type hinting

python-client/giskard/ml_worker/testing/registry/slicing_function.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def inner(func: Union[SlicingFunctionType, Type[SlicingFunction]]) -> SlicingFun
147147
if inspect.isclass(func) and issubclass(func, SlicingFunction):
148148
return func
149149

150-
return _wrap_slicing_function(func, row_level, cell_level)#()
150+
return _wrap_slicing_function(func, row_level, cell_level)
151151

152152
if callable(_fn):
153153
return functools.wraps(_fn)(inner(_fn))

python-client/giskard/settings.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ class Settings(BaseModel):
3131
ws_path: str = "/ml-worker"
3232
host: str = "localhost"
3333
max_workers: int = 10
34-
max_send_message_length_mb: int = 1024
35-
max_receive_message_length_mb: int = 1024
3634
loglevel: str = "INFO"
3735
cache_dir: str = "cache"
3836
disable_analytics: bool = False

0 commit comments

Comments
 (0)