Fast failing

Author: Hartorn

.github/workflows/build-python.yml

@@ -10,29 +10,29 @@ on:
   workflow_dispatch:
     inputs:
       run-integration-tests:
-        description: 'If integration test should be run'
+        description: "If integration test should be run"
         required: true
         type: boolean
         default: false
       use-cache:
-        description: 'If cache should be used'
+        description: "If cache should be used"
         required: true
         type: boolean
         default: true
       is-dispatch:
-        description: 'Just to identify manual dispatch'
+        description: "Just to identify manual dispatch"
         required: true
         type: boolean
         default: true
   workflow_call:
     inputs:
       run-integration-tests:
-        description: 'If integration test should be run'
+        description: "If integration test should be run"
         required: true
         type: boolean
         default: false
       use-cache:
-        description: 'If cache should be used'
+        description: "If cache should be used"
         required: true
         type: boolean
         default: false
@@ -53,7 +53,7 @@ jobs:
     strategy:
       fail-fast: false # Do not stop when any job fails
       matrix:
-        python-version: [ "3.9", "3.10", "3.11" ]
+        python-version: ["3.9", "3.10", "3.11"]
         os: [ubuntu-latest]
         pydantic_v1: [false]
         pandas_v1: [false]
@@ -116,8 +116,6 @@ jobs:
           pdm install -G :all
           pdm list
 
-      - name: Lint code
-        run: pdm run lint
       - name: Re-install lightgbm from sources for MacOS
         if: ${{ matrix.os == 'macos-latest' }}
         run: |
@@ -157,6 +155,9 @@ jobs:
           pdm run pip freeze | grep '^pandas'
           pdm run pip freeze | grep -q '^pandas==${{ matrix.pandas_v1 && '1' || '2' }}\.'
 
+      - name: Lint code
+        run: pdm run lint
+
       - name: Test code (concurrency)
         run: pdm test-worker
 
@@ -205,7 +206,7 @@ jobs:
       - name: Setup PDM
         uses: pdm-project/setup-pdm@v3
         with:
-          python-version: '3.10'
+          python-version: "3.10"
           cache: false
       - name: Build wheel
         run: pdm build
@@ -233,7 +234,7 @@ jobs:
       - name: Setup PDM
         uses: pdm-project/setup-pdm@v3
         with:
-          python-version: '3.10'
+          python-version: "3.10"
           cache: false
       - name: Build wheel
         run: pdm build
@@ -252,8 +253,8 @@ jobs:
       - name: Setup PDM
         uses: pdm-project/setup-pdm@v3
         with:
-          python-version: '3.10'
-          version: '2.10.4' # Fix to repair the CI, use latest version when fixed on pdm
+          python-version: "3.10"
+          version: "2.10.4" # Fix to repair the CI, use latest version when fixed on pdm
           cache: false
       - name: Build wheel
         run: pdm build
@@ -291,7 +292,7 @@ jobs:
       - name: Set up Pandoc (needed for doc)
         uses: r-lib/actions/setup-pandoc@v2
         with:
-          pandoc-version: '3.1.7' # https://github.com/jgm/pandoc/releases
+          pandoc-version: "3.1.7" # https://github.com/jgm/pandoc/releases
 
       - name: Install dependencies
         run: pdm install -G :all

tests/integrations/test_mlflow.py

@@ -1,3 +1,4 @@
+import os
 from pathlib import Path
 from tempfile import TemporaryDirectory
 
@@ -20,10 +21,11 @@ def _evaluate(dataset, model, evaluator_config):
         # MLFlow logic for windows seems to say : "Start with drive, no need for file:"
         # https://github.com/mlflow/mlflow/blob/b414a22bdead12a1865a0ab59460eb6b158db7d0/mlflow/utils/uri.py#L65C1-L66C1
         # Since it's not working, let's just skip it for windows..
-        if platform.system() != "Windows":
-            mlflow.set_tracking_uri(Path(f))
+        if platform.system() == "Windows":
+            f = "file:/" + f.replace(os.sep, "/")
+            mlflow.set_tracking_uri(f)
         else:
-            mlflow.set_registry_uri("")
+            mlflow.set_tracking_uri(Path(f))
         experiment_id = mlflow.create_experiment("test", artifact_location=f)
         with mlflow.start_run(experiment_id=experiment_id):
             model_info = model.to_mlflow()