Skip to content

Commit d0728c6

Browse files
committed
Fixed newline issue when reading env file
1 parent ae77016 commit d0728c6

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

giskard/commands/cli_hub.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
import os
33
import time
44
from pathlib import Path
5-
from typing import Optional
65

76
import click
87
import docker
@@ -14,6 +13,7 @@
1413
from packaging import version
1514
from packaging.version import InvalidVersion, Version
1615
from tenacity import retry, wait_exponential
16+
from typing import Optional
1717

1818
import giskard
1919
from giskard.cli_utils import common_options
@@ -334,7 +334,9 @@ def start(attached, skip_version_check, version, environment, env_file):
334334
environment = list(environment)
335335
if env_file is not None:
336336
with open(env_file, "r") as f:
337-
environment = f.readlines() + environment
337+
environment = f.read().splitlines() + environment
338+
339+
print(environment)
338340

339341
_start(attached, skip_version_check, version, environment)
340342

0 commit comments

Comments
 (0)