Skip to content

Commit dfb33df

Browse files
committed
another try
1 parent 16adabb commit dfb33df

2 files changed

Lines changed: 13 additions & 4 deletions

File tree

.github/workflows/build-python.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,6 @@ jobs:
116116
pdm install -G :all
117117
pdm list
118118
119-
- name: Lint code
120-
run: pdm run lint
121119
- name: Re-install lightgbm from sources for MacOS
122120
if: ${{ matrix.os == 'macos-latest' }}
123121
run: |
@@ -160,6 +158,9 @@ jobs:
160158
- name: Test mlflow
161159
run: pdm run pytest tests/integrations/test_mlflow.py::test_fast[diabetes_dataset_with_target-linear_regression_diabetes]
162160

161+
- name: Lint code
162+
run: pdm run lint
163+
163164
- name: Test code (concurrency)
164165
run: pdm test-worker
165166

tests/integrations/test_mlflow.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,18 @@
1414

1515

1616
def _evaluate(dataset, model, evaluator_config):
17+
import os
18+
import platform
19+
1720
with TemporaryDirectory() as f:
18-
mlflow.set_tracking_uri(Path(f))
19-
# MLFlow logic for windows seems to say : "Start with drive, no need for file:"
2021
# https://github.com/mlflow/mlflow/blob/b414a22bdead12a1865a0ab59460eb6b158db7d0/mlflow/utils/uri.py#L65C1-L66C1
22+
# MLFlow logic for windows seems to say : "Start with drive, no need for file:"
23+
# if platform.system() == "Windows":
24+
# f = f.replace(os.sep, "/")
25+
# f = "file://" + f
26+
# mlflow.set_tracking_uri(Path(f))
27+
# else:
28+
mlflow.set_tracking_uri(f"file://{f}")
2129
experiment_id = mlflow.create_experiment("test", artifact_location=f)
2230
with mlflow.start_run(experiment_id=experiment_id):
2331
model_info = model.to_mlflow()

0 commit comments

Comments
 (0)