Skip to content

Commit e80ca29

Browse files
committed
Add unit tests for DTO serialization in push (python)
(Squashed commits of @Inokinoki) Contributes to #GSK-1508
1 parent bf1502f commit e80ca29

6 files changed

Lines changed: 3199 additions & 291 deletions

File tree

giskard/ml_worker/websocket/utils.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -297,20 +297,16 @@ def function_argument_to_ws(value: Dict[str, Any]):
297297
args=function_argument_to_ws(obj.params),
298298
none=False,
299299
)
300-
# arguments[arg.name] = SlicingFunction.load(arg.slicingFunction.id, self.client, None)(
301-
# **self.parse_function_arguments(arg.args))
302300
elif isinstance(obj, TransformationFunction):
303301
funcargs = websocket.FuncArgument(
304302
name=v,
305303
transformationFunction=websocket.ArtifactRef(project_key="test", id=str(obj.meta.uuid)),
306304
args=function_argument_to_ws(obj.params),
307305
none=False,
308306
)
309-
# arguments[arg.name] = TransformationFunction.load(arg.transformationFunction.id, self.client, None)(
310-
# **self.parse_function_arguments(arg.args))
311307
elif isinstance(obj, float):
312308
funcargs = websocket.FuncArgument(name=v, float=obj, none=False)
313-
elif isinstance(obj, int):
309+
elif isinstance(obj, int) and not isinstance(obj, bool): # Avoid bool being considered as int
314310
funcargs = websocket.FuncArgument(name=v, int=obj, none=False)
315311
elif isinstance(obj, str):
316312
funcargs = websocket.FuncArgument(name=v, str=obj, none=False)

0 commit comments

Comments
 (0)