Squash merge better-slack-notifications

commit 99969d3
Author: Jocelyn Vernay <jocelyn@giskard.ai>
Date:   Thu Feb 1 14:16:54 2024 +0100

    Update slack steps names

commit ffa2410
Author: Jocelyn Vernay <jocelyn@giskard.ai>
Date:   Thu Feb 1 13:03:35 2024 +0100

    Trim post-release

commit e226ab2
Author: vjern <jocelyn@giskard.ai>
Date:   Thu Feb 1 11:46:05 2024 +0100

    Update release start message

commit 4f75209
Author: vjern <jocelyn@giskard.ai>
Date:   Thu Feb 1 11:42:58 2024 +0100

    Fix `@channel` mention in create-release

commit 3cf411e
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Wed Jan 31 18:48:25 2024 +0100

    Add more slack notif ideas

commit b53ce12
Merge: 69901b5 c5da6cf
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Wed Jan 31 16:59:06 2024 +0100

    Merge remote-tracking branch 'origin/feature/gsk-2574-improve-release-step' into feature/gsk-2574-better-slack-notifications

commit c5da6cf
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Wed Jan 31 16:47:20 2024 +0100

    Make slack channel id a repo Actions variable

commit 5d3f2ce
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Wed Jan 31 16:29:01 2024 +0100

    Fix `@channel` mention in post-release slack notif

commit 69901b5
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Wed Jan 31 16:00:08 2024 +0100

    Enable reploy_broadcast in post-release slack msg

commit c494b43
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Wed Jan 31 15:57:44 2024 +0100

    Expect and use slack thread id in post-release

commit c5706de
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Wed Jan 31 15:57:30 2024 +0100

    Add release author to release start message

commit f07a3f4
Merge: 402acf4 931f00e
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Wed Jan 31 15:46:13 2024 +0100

    Merge branch 'feature/gsk-2574-improve-release-step' into feature/gsk-2574-better-slack-notifications

commit 931f00e
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Wed Jan 31 15:20:32 2024 +0100

    Fix @channel slack message

commit b96f21f
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Wed Jan 31 12:00:37 2024 +0100

    Add release pat token to post-release checkout

commit 973f548
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Wed Jan 31 11:48:40 2024 +0100

    Set wheel artifact retention period & err behavior

commit f3ea326
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Wed Jan 31 11:44:35 2024 +0100

    Name rc wheel artifact after input version number

commit 402acf4
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Wed Jan 31 10:44:15 2024 +0100

    Add release process start slack notification

commit d942b8d
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Wed Jan 31 10:41:49 2024 +0100

    Send success slack notif after publishing to pypi

commit d1211af
Merge: f4bd867 5ff5cd3
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Tue Jan 30 18:05:49 2024 +0100

    Merge branch 'feature/gsk-2574-improve-release-step' of github.com:Giskard-AI/giskard into feature/gsk-2574-improve-release-step

commit f4bd867
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Tue Jan 30 18:05:06 2024 +0100

    Reset build-python

commit 5ff5cd3
Merge: 15386e3 1b724c6
Author: Jocelyn Vernay <59055698+vjern@users.noreply.github.com>
Date:   Tue Jan 30 14:38:34 2024 +0100

    Merge branch 'main' into feature/gsk-2574-improve-release-step

commit 15386e3
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Tue Jan 30 14:33:00 2024 +0100

    Restore step ifs and remove dev comments

commit deb70a8
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Tue Jan 30 14:26:45 2024 +0100

    Restore other diff spans unrelated to feature

commit 439e7df
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Tue Jan 30 14:24:05 2024 +0100

    Restore org member check steps

commit 1867aae
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Tue Jan 30 14:23:33 2024 +0100

    Remove  do-release

commit b86a9e4
Author: BotReleaser <bot.releaser@users.noreply.github.com>
Date:   Tue Jan 30 14:22:00 2024 +0100

    Reset README

Author: vjern

.github/workflows/build-python.yml

@@ -6,8 +6,6 @@ on:
   push:
     branches:
       - main
-    paths-ignore:
-      - .github/**
   pull_request:
   workflow_dispatch:
     inputs:
@@ -168,8 +166,7 @@ jobs:
           PYTEST_XDIST_AUTO_NUM_WORKERS: 2
 
       - name: SonarCloud Scan
-        if: false
-        # if: ${{ matrix.os == 'ubuntu-latest' && matrix.python-version == '3.10' && !matrix.langchain_minimal && !matrix.pandas_v1 && !matrix.pydantic_v1 && (github.event.ref == 'refs/heads/main' || github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository)}}
+        if: ${{ matrix.os == 'ubuntu-latest' && matrix.python-version == '3.10' && !matrix.langchain_minimal && !matrix.pandas_v1 && !matrix.pydantic_v1 && (github.event.ref == 'refs/heads/main' || github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name == github.repository)}}
         uses: SonarSource/sonarcloud-github-action@v2.1.1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/create-release.yml

@@ -8,6 +8,7 @@ on:
           required: true
           type: string
 
+
 jobs:
   build:
     runs-on: ubuntu-latest
@@ -20,12 +21,12 @@ jobs:
           username: ${{ github.actor }}
           token: ${{ secrets.GITHUB_TOKEN }}
 
-      # - name: Interrupt job
-      #   if: ${{ steps.is_organization_member.outputs.result == 'false' }}
-      #   shell: bash
-      #   run: |
-      #     echo "Job failed due to user not being a member of Giskard-AI organization and the 'safe for build' label not being set on the PR"
-      #     exit 1
+      - name: Interrupt job
+        if: ${{ steps.is_organization_member.outputs.result == 'false' }}
+        shell: bash
+        run: |
+          echo "Job failed due to user not being a member of Giskard-AI organization and the 'safe for build' label not being set on the PR"
+          exit 1
 
       - name: Checkout code
         uses: actions/checkout@v4.1.0
@@ -47,16 +48,25 @@ jobs:
         run: pdm build
 
       - name: Upload RC wheel artifact
-        # Upload needs to be done only once by workflo run, so we need to select one only in the matrix
-        # FIXME are these all the defaults in the current workflow ?
-        # if: ${{ github.event_name == 'push' && matrix.os == 'ubuntu-latest' && matrix.python-version == '3.10' && !matrix.langchain_minimal && !matrix.pandas_v1 && !matrix.pydantic_v1 }}
         uses: actions/upload-artifact@v4
         with:
           name: rc-wheel-${{ inputs.version }}
           path: dist/*whl
           if-no-files-found: error
           retention-days: 1
 
+      - name: "@slack Release process started"
+        id: slack
+        uses: slackapi/slack-github-action@v1.24.0
+        with:
+          channel-id: ${{ secrets.SLACK_CHANNEL_ID }}
+          slack-message: |
+            <!channel> New release **v${{ inputs.version }}** has been triggered by @${{ github.actor }} :rocket:
+        env:
+          SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
+          if-no-files-found: error
+          retention-days: 1
+
       - name: Trigger release process in giskard-hub
         uses: peter-evans/repository-dispatch@v2
         with:
@@ -65,5 +75,6 @@ jobs:
           repository: ${{ github.repository_owner }}/giskard-hub
           client-payload: |
             {
-              "version_name": "v${{ inputs.version }}"
+              "version_name": "v${{ inputs.version }}",
+              "slack_thread_id": "${{ steps.slack.outputs.thread_ts }}"
             }

.github/workflows/do-release.yml

@@ -1,7 +1,7 @@
 name: Nightly test
 on:
-  # schedule:
-  #   - cron: '0 1 * * *' # Always run at 1:00 a.m.
+  schedule:
+    - cron: '0 1 * * *' # Always run at 1:00 a.m.
   workflow_dispatch:
 
 jobs:

.github/workflows/nightly-test.yml

@@ -6,6 +6,7 @@ on:
       - post-release
       # Client payload should contain
       # version_name: vX.Y.Z (with prefix)
+      # slack_thread_id: (Also named thread_ts == thread timestamp == timestamp of the first message)
 permissions:
   contents: write
 
@@ -105,16 +106,30 @@ jobs:
       - name: Push to Pipy
         if: false
         run: pdm publish --no-build --username "${{ secrets.PIPY_USERNAME }}" --password "${{ secrets.PIPY_PASSWORD }}"
-  
-      - name: Post to a Slack channel
-        id: slack
+
+      - name: Set job success env var
+        run: |
+          echo "JOB_SUCCESS=true" >> $GITHUB_ENV
+
+      - name: "@slack Share release process completion"
+        # # cancellable always() https://docs.github.com/en/actions/learn-github-actions/expressions#status-check-functions
+        if: !cancelled()
         uses: slackapi/slack-github-action@v1.24.0
-        with:
-          # Slack channel id, channel name, or user id to post message.
-          # See also: https://api.slack.com/methods/chat.postMessage#channels
-          # On special mentions: https://api.slack.com/reference/surfaces/formatting#special-mentions
-          channel-id: ${{ vars.SLACK_CHANNEL_ID }}
-          slack-message: "<!channel> New release: ${{ env.VERSION_NAME }} is being made !:tada:\nRelease notes there: ${{ steps.github-release.outputs.url }}"
-          # For posting a rich message using Block Kit
         env:
           SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
+          ON_SUCCESS: |
+            <!channel>
+            Release **${{ env.VERSION_NAME }}** has been published ! :tada:
+            [Release notes](${{ steps.github-release.outputs.url }}) | [PyPI](https://pypi.org/project/giskard/${{ env.VERSION_NUMBER }})
+          ON_FAILURE: |
+            "<!channel> Release ${{ env.VERSION_NAME }} failed on post-release :cross:
+            [Logs](${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }})
+        with:
+          channel-id: ${{ vars.SLACK_CHANNEL_ID }}
+          slack-message: ${{ env.JOB_SUCCESS == 'true' && env.ON_SUCCESS || env.ON_FAILURE }}
+          # reploy_broadcast == also send to channel
+          payload: |
+            {
+              "thread_ts": "${{ inputs.slack_thread_id }}",
+              "reply_broadcast": true
+            }

.github/workflows/post-release.yml

@@ -1,4 +1,4 @@
-<p align="center">  
+<p align="center">
   <img alt="giskardlogo" src="readme/giskard_logo.png#gh-light-mode-only">
   <img alt="giskardlogo" src="readme/giskard_logo_green.png#gh-dark-mode-only">
 </p>