Skip to content

Commit 2267902

Browse files
authored
MINOR: Mark streams RPCs as unstable (#19292)
Streams groups RPCs are not enabled by default, but they should also be marked as unstable. Reviewers: Bruno Cadonna <cadonna@apache.org>
1 parent 9e42b76 commit 2267902

4 files changed

Lines changed: 10 additions & 2 deletions

File tree

clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ private NetworkClientDelegate.UnsentRequest makeHeartbeatRequestAndHandleRespons
476476

477477
private NetworkClientDelegate.UnsentRequest makeHeartbeatRequest(final long currentTimeMs) {
478478
NetworkClientDelegate.UnsentRequest request = new NetworkClientDelegate.UnsentRequest(
479-
new StreamsGroupHeartbeatRequest.Builder(this.heartbeatState.buildRequestData()),
479+
new StreamsGroupHeartbeatRequest.Builder(this.heartbeatState.buildRequestData(), true),
480480
coordinatorRequestManager.coordinator()
481481
);
482482
heartbeatRequestState.onSendAttempt(currentTimeMs);

clients/src/main/resources/common/message/StreamsGroupDescribeRequest.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
"name": "StreamsGroupDescribeRequest",
2121
"validVersions": "0",
2222
"flexibleVersions": "0+",
23+
// The StreamsGroupDescribeRequest API is added as part of KIP-1071 and is still under
24+
// development. Hence, the API is not exposed by default by brokers unless
25+
// explicitly enabled.
26+
"latestVersionUnstable": true,
2327
"fields": [
2428
{ "name": "GroupIds", "type": "[]string", "versions": "0+", "entityType": "groupId",
2529
"about": "The ids of the groups to describe" },

clients/src/main/resources/common/message/StreamsGroupHeartbeatRequest.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
"name": "StreamsGroupHeartbeatRequest",
2121
"validVersions": "0",
2222
"flexibleVersions": "0+",
23+
// The StreamsGroupDescribeRequest API is added as part of KIP-1071 and is still under
24+
// development. Hence, the API is not exposed by default by brokers unless
25+
// explicitly enabled.
26+
"latestVersionUnstable": true,
2327
"fields": [
2428
{ "name": "GroupId", "type": "string", "versions": "0+", "entityType": "groupId",
2529
"about": "The group identifier." },

core/src/test/scala/unit/kafka/server/KafkaApisTest.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9652,7 +9652,7 @@ class KafkaApisTest extends Logging {
96529652
def testStreamsGroupHeartbeatReturnsUnsupportedVersion(): Unit = {
96539653
val streamsGroupHeartbeatRequest = new StreamsGroupHeartbeatRequestData().setGroupId("group")
96549654

9655-
val requestChannelRequest = buildRequest(new StreamsGroupHeartbeatRequest.Builder(streamsGroupHeartbeatRequest).build())
9655+
val requestChannelRequest = buildRequest(new StreamsGroupHeartbeatRequest.Builder(streamsGroupHeartbeatRequest, true).build())
96569656
metadataCache = {
96579657
val cache = new KRaftMetadataCache(brokerId, () => KRaftVersion.KRAFT_VERSION_1)
96589658
val delta = new MetadataDelta(MetadataImage.EMPTY);

0 commit comments

Comments
 (0)