Skip to content

Commit 4bb8f0f

Browse files
authored
MINOR: Fix duplicate args in KStreamSessionWindowAggregateProcessorTest (#22183)
The `emitStrategyAndHeadersMatrix()` currently returns four entries but they are duplicates of ON_WINDOW_UPDATE (and therefore also runs each case twice). This also drops coverage for EmitStrategy.StrategyType.ON_WINDOW_CLOSE, which was previously covered via @EnumSource. Update the method source to generate the full matrix of strategy type(s) and withHeaders values (eg, include both ON_WINDOW_UPDATE and ON_WINDOW_CLOSE, each with withHeaders=false/true) without duplicates. Reviewers: Murali Basani <muralidhar.basani@aiven.io>, Matthias J. Sax <matthias@confluent.io>
1 parent 5645518 commit 4bb8f0f

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSessionWindowAggregateProcessorTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,8 @@ public static Stream<Arguments> emitStrategyAndHeadersMatrix() {
105105
return Stream.of(
106106
Arguments.of(EmitStrategy.StrategyType.ON_WINDOW_UPDATE, true),
107107
Arguments.of(EmitStrategy.StrategyType.ON_WINDOW_UPDATE, false),
108-
Arguments.of(EmitStrategy.StrategyType.ON_WINDOW_UPDATE, true),
109-
Arguments.of(EmitStrategy.StrategyType.ON_WINDOW_UPDATE, false)
108+
Arguments.of(EmitStrategy.StrategyType.ON_WINDOW_CLOSE, true),
109+
Arguments.of(EmitStrategy.StrategyType.ON_WINDOW_CLOSE, false)
110110
);
111111
}
112112

0 commit comments

Comments
 (0)