fix: Replace custom toBoolean with parseBooleanOrNull (#772)

test: Replace custom `toBoolean` with `parseBooleanOrNull` utility and consolidate related test cases. Also consolidate evals.config.test.ts

Author: jirispilka

src/input.ts

@@ -6,18 +6,10 @@
  * intent via `undefined` (use defaults later) vs empty (explicitly none).
  */
 import log from '@apify/log';
+import { parseBooleanOrNull } from '@apify/utilities';
 
 import type { Input, ToolSelector } from './types.js';
 
-// Helpers
-// Normalize booleans that may arrive as strings or be undefined.
-export function toBoolean(value: unknown, defaultValue: boolean): boolean {
-    if (value === undefined) return defaultValue;
-    if (typeof value === 'boolean') return value;
-    if (typeof value === 'string') return value.toLowerCase() === 'true';
-    return defaultValue;
-}
-
 // Normalize lists from comma-separated strings or arrays.
 export function normalizeList(value: string | unknown[] | undefined): string[] | undefined {
     if (value === undefined) return undefined;
@@ -46,9 +38,9 @@ export function processInput(originalInput: Partial<Input>): Input {
     let enableAddingActors: boolean;
     if (originalInput.enableAddingActors === undefined && originalInput.enableActorAutoLoading !== undefined) {
         log.warning('enableActorAutoLoading is deprecated, use enableAddingActors instead');
-        enableAddingActors = toBoolean(originalInput.enableActorAutoLoading, false);
+        enableAddingActors = parseBooleanOrNull(originalInput.enableActorAutoLoading) ?? false;
     } else {
-        enableAddingActors = toBoolean(originalInput.enableAddingActors, false);
+        enableAddingActors = parseBooleanOrNull(originalInput.enableAddingActors) ?? false;
     }
 
     // Normalize tools (strings/arrays) to a clean array or undefined

tests/unit/evals.config.test.ts

@@ -3,59 +3,38 @@ import { afterEach, describe, expect, it } from 'vitest';
 import { sanitizeEnvValue, sanitizeProcessEnv } from '../../evals/shared/config.js';
 
 describe('sanitizeEnvValue', () => {
-    it('returns undefined for undefined', () => {
+    it('passes through undefined and null', () => {
         expect(sanitizeEnvValue(undefined)).toBeUndefined();
-    });
-
-    it('returns null for null', () => {
         expect(sanitizeEnvValue(null as unknown as undefined)).toBeNull();
     });
 
-    it('strips trailing newline', () => {
+    it('strips newlines and trims surrounding whitespace', () => {
         expect(sanitizeEnvValue('sk-abc123\n')).toBe('sk-abc123');
-    });
-
-    it('strips carriage-return + newline', () => {
         expect(sanitizeEnvValue('sk-abc123\r\n')).toBe('sk-abc123');
-    });
-
-    it('strips embedded newlines', () => {
         expect(sanitizeEnvValue('sk-\nabc\r\n123\n')).toBe('sk-abc123');
-    });
-
-    it('trims surrounding whitespace', () => {
         expect(sanitizeEnvValue('  sk-abc123  ')).toBe('sk-abc123');
     });
 
-    it('strips surrounding double quotes', () => {
-        expect(sanitizeEnvValue('"sk-abc123"')).toBe('sk-abc123');
+    it('strips control characters', () => {
+        expect(sanitizeEnvValue('sk-abc\x00123')).toBe('sk-abc123'); // null byte
+        expect(sanitizeEnvValue('sk-abc\x01123')).toBe('sk-abc123'); // SOH
+        expect(sanitizeEnvValue('sk-abc\x0b123')).toBe('sk-abc123'); // vertical tab
+        expect(sanitizeEnvValue('sk-abc\x0c123')).toBe('sk-abc123'); // form feed
+        expect(sanitizeEnvValue('sk-abc\x1f123')).toBe('sk-abc123'); // unit separator
+        expect(sanitizeEnvValue('sk-abc\x7f123')).toBe('sk-abc123'); // DEL
     });
 
-    it('strips only outer quotes (not inner)', () => {
+    it('strips surrounding double quotes only', () => {
+        expect(sanitizeEnvValue('"sk-abc123"')).toBe('sk-abc123');
         expect(sanitizeEnvValue('"sk-"abc"-123"')).toBe('sk-"abc"-123');
-    });
-
-    it('does not strip single quotes', () => {
         expect(sanitizeEnvValue("'sk-abc123'")).toBe("'sk-abc123'");
     });
 
-    it('handles combined whitespace, newlines, and quotes', () => {
+    it('handles combined inputs and edge cases', () => {
         expect(sanitizeEnvValue('  "sk-abc123"\n')).toBe('sk-abc123');
-    });
-
-    it('returns empty string for empty input', () => {
         expect(sanitizeEnvValue('')).toBe('');
     });
 
-    it('strips control characters', () => {
-        expect(sanitizeEnvValue('sk-abc\x00123')).toBe('sk-abc123'); // null byte
-        expect(sanitizeEnvValue('sk-abc\x01123')).toBe('sk-abc123'); // SOH
-        expect(sanitizeEnvValue('sk-abc\x0b123')).toBe('sk-abc123'); // vertical tab
-        expect(sanitizeEnvValue('sk-abc\x0c123')).toBe('sk-abc123'); // form feed
-        expect(sanitizeEnvValue('sk-abc\x1f123')).toBe('sk-abc123'); // unit separator
-        expect(sanitizeEnvValue('sk-abc\x7f123')).toBe('sk-abc123'); // DEL
-    });
-
     it('is idempotent', () => {
         const value = '  "sk-abc123"\r\n';
         expect(sanitizeEnvValue(sanitizeEnvValue(value))).toBe(sanitizeEnvValue(value));