Ignas: experimental_ prefix

Author: arrdem

examples/build_file_generation/WORKSPACE

@@ -105,7 +105,7 @@ pip_parse(
 
     # Requirement groups allow Bazel to tolerate PyPi cycles by putting dependencies
     # which are known to form cycles into groups together.
-    requirement_cycles = {
+    experimental_requirement_cycles = {
         "sphinx": [
             "sphinx",
             "sphinxcontrib-qthelp",

examples/bzlmod/MODULE.bazel

@@ -90,7 +90,7 @@ use_repo(pip, "whl_mods_hub")
 pip.parse(
     hub_name = "pip",
     python_version = "3.9",
-    requirement_cycles = {
+    experimental_requirement_cycles = {
         "sphinx": [
             "sphinx",
             "sphinxcontrib-qthelp",
@@ -113,7 +113,7 @@ pip.parse(
 pip.parse(
     hub_name = "pip",
     python_version = "3.10",
-    requirement_cycles = {
+    experimental_requirement_cycles = {
         "sphinx": [
             "sphinx",
             "sphinxcontrib-qthelp",

examples/pip_parse/WORKSPACE

@@ -43,7 +43,7 @@ pip_parse(
 
     # Requirement groups allow Bazel to tolerate PyPi cycles by putting dependencies
     # which are known to form cycles into groups together.
-    requirement_cycles = {
+    experimental_requirement_cycles = {
         "sphinx": [
             "sphinx",
             "sphinxcontrib-qthelp",

python/pip_install/pip_repository.bzl

@@ -283,7 +283,7 @@ def _pip_repository_impl(rctx):
     # Normalize cycles first
     requirement_cycles = {
         name: sorted(sets.to_list(sets.make(deps)))
-        for name, deps in rctx.attr.requirement_cycles.items()
+        for name, deps in rctx.attr.experimental_requirement_cycles.items()
     }
 
     # Check for conflicts between cycles _before_ we normalize package names so
@@ -296,7 +296,7 @@ def _pip_repository_impl(rctx):
             right_group = requirement_cycles.keys()[1 + i + j]
             for d in left_deps:
                 if d in right_deps:
-                    fail("Error: Requirement %s is repeated between cycles %s and %s, they must be merged." % (d, left_group, right_group))
+                    fail("Error: Requirement %s cannot be repeated between cycles %s and %s; please merge the cycles." % (d, left_group, right_group))
 
     # And normalize the names as used in the cycle specs
     #
@@ -459,7 +459,7 @@ python_interpreter. An example value: "@python3_x86_64-unknown-linux-gnu//:pytho
 Prefix for the generated packages will be of the form `@<prefix><sanitized-package-name>//...`
 """,
     ),
-    "requirement_cycles": attr.string_list_dict(
+    "experimental_requirement_cycles": attr.string_list_dict(
         default = {},
         doc = """\
 A mapping of dependency cycle names to a list of requirements which form that cycle.
@@ -500,7 +500,7 @@ Example:
   ```
   pip_parse(
     ...
-    requirement_cycles = {
+    experimental_requirement_cycles = {
       "sphinx": [
         "sphinx",
         "sphinxcontrib-serializinghtml",

python/private/bzlmod/pip.bzl

@@ -122,7 +122,7 @@ def _create_whl_repos(module_ctx, pip_attr, whl_map, whl_overrides):
 
     requirement_cycles = {
         name: [normalize_name(whl_name) for whl_name in whls]
-        for name, whls in pip_attr.requirement_cycles.items()
+        for name, whls in pip_attr.experimental_requirement_cycles.items()
     }
 
     whl_group_mapping = {
@@ -135,7 +135,7 @@ def _create_whl_repos(module_ctx, pip_attr, whl_map, whl_overrides):
     group_library(
         name = group_repo,
         repo_prefix = pip_name + "_",
-        groups = pip_attr.requirement_cycles,
+        groups = pip_attr.experimental_requirement_cycles,
     )
 
     # Create a new wheel library for each of the different whls