Add tests for rsync_rsh helper and improve argument type handling

Author: antonmedv

src/Support/helpers.php

@@ -256,6 +256,9 @@ function rsync_rsh(array $args): string
 {
     $parts = ['ssh'];
     foreach ($args as $option) {
+        if (is_integer($option)) {
+            $option = (string) $option;
+        }
         if (str_contains($option, "\0")) {
             throw new \InvalidArgumentException('rsync_rsh: NUL byte not allowed in ssh option');
         }

tests/issues/PortIntTest.php

@@ -59,4 +59,11 @@ public function testParseHomeDir()
         $this->assertStringStartsWith('~', parse_home_dir('~path'));
         $this->assertStringEndsWith('~', parse_home_dir('path~'));
     }
+
+    public function testRsyncRsh()
+    {
+        $this->assertEquals("ssh -p 22", rsync_rsh(['-p', 22]));
+        $this->assertEquals("ssh 'argument with spaces'", rsync_rsh(['argument with spaces']));
+        $this->assertEquals("ssh 'argument with '' quote'", rsync_rsh(['argument with \' quote']));
+    }
 }