Restore original getCodeQLActionRepository behaviour

Author: Simon Engledew

CHANGELOG.md

@@ -2,8 +2,7 @@
 
 ## [UNRELEASED]
 
-No user facing changes.
-
+- Fix `RUNNER_TEMP environment variable must be set` when using runner.
 ## 1.0.3 - 23 Jun 2021
 
 No user facing changes.

lib/codeql.js

@@ -374,19 +374,21 @@ test("getExtraOptions throws for bad content", (t) => {
 test("getCodeQLActionRepository", (t) => {
   const logger = getRunnerLogger(true);
 
+  process.env["RUNNER_TEMP"] = path.dirname(__dirname);
+
   initializeEnvironment(Mode.actions, "1.2.3");
   const repoActions = codeql.getCodeQLActionRepository(logger);
   t.deepEqual(repoActions, "github/codeql-action");
 
+  process.env["GITHUB_ACTION_REPOSITORY"] = "xxx/yyy";
+  const repoEnv = codeql.getCodeQLActionRepository(logger);
+  t.deepEqual(repoEnv, "xxx/yyy");
+
   initializeEnvironment(Mode.runner, "1.2.3");
 
   // isRunningLocalAction() === true
   delete process.env["GITHUB_ACTION_REPOSITORY"];
   process.env["RUNNER_TEMP"] = path.dirname(__dirname);
   const repoLocalRunner = codeql.getCodeQLActionRepository(logger);
   t.deepEqual(repoLocalRunner, "github/codeql-action");
-
-  process.env["GITHUB_ACTION_REPOSITORY"] = "xxx/yyy";
-  const repoEnv = codeql.getCodeQLActionRepository(logger);
-  t.deepEqual(repoEnv, "xxx/yyy");
 });

lib/codeql.js.map

@@ -175,7 +175,7 @@ function getCodeQLBundleName(): string {
 }
 
 export function getCodeQLActionRepository(logger: Logger): string {
-  if (util.isActions()) {
+  if (!util.isActions()) {
     return CODEQL_DEFAULT_ACTION_REPOSITORY;
   } else {
     return getActionsCodeQLActionRepository(logger);