Skip to content

Commit 678615c

Browse files
Copilotpelikhan
andauthored
docs(specs): address review feedback on aw-harness W3C spec
- Clarify MUST NOT wording: 'MUST NOT honor attempts to disable' - Add normative requirement to emit a stderr warning when cli-proxy or tools.github.mode overrides are applied, aiding author debugging Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
1 parent 8f6af71 commit 678615c

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

specs/aw-harness.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ The AW Harness is the topmost layer within the gh-aw container. The following AS
214214

215215
4. **Optimized for gh-aw container.** The harness **MUST** assume that the firewall, api-proxy, and MCP gateway are already running. It **MUST NOT** perform direct LLM API calls, redundant authentication, or network configuration.
216216

217-
5. **`gh-proxy` and `cli-proxy` always on.** The Pi SDK does not support MCP natively. GitHub and other MCP server tools are bridged into Pi via the `mcp-bridge` extension. This bridge **REQUIRES** both `gh-proxy` (pre-authenticated `gh` CLI in bash) and `cli-proxy` (MCP servers mounted as CLI tools on `PATH`). A conforming implementation **MUST** enable both `gh-proxy` and `cli-proxy` when `engine: aw` is selected. An implementation **MUST NOT** allow these features to be disabled for `engine: aw`, regardless of the values specified in the workflow frontmatter (see [Section 6.2](#62-overrides-and-fixed-settings)).
217+
5. **`gh-proxy` and `cli-proxy` always on.** The Pi SDK does not support MCP natively. GitHub and other MCP server tools are bridged into Pi via the `mcp-bridge` extension. This bridge **REQUIRES** both `gh-proxy` (pre-authenticated `gh` CLI in bash) and `cli-proxy` (MCP servers mounted as CLI tools on `PATH`). A conforming implementation **MUST** enable both `gh-proxy` and `cli-proxy` when `engine: aw` is selected. A conforming implementation **MUST NOT** honor attempts to disable these features for `engine: aw`, regardless of the values specified in the workflow frontmatter (see [Section 6.2](#62-overrides-and-fixed-settings)).
218218

219219
6. **TypeScript → Node 24.** Source **MUST** be TypeScript, compiled to ES2024, bundled via esbuild to a single `.cjs`. Leverages Node 24 features (native fetch, `structuredClone`, `AbortSignal.any`).
220220

@@ -439,7 +439,7 @@ A conforming implementation **MUST** apply the following overrides regardless of
439439
| `cli-proxy` | `true` | Required for MCP bridge functionality |
440440
| `tools.github.mode` | `gh-proxy` | Pi SDK requires `gh-proxy`; `remote` mode is not supported |
441441
442-
A conforming implementation **MUST NOT** honor `cli-proxy: false` or `tools.github.mode: remote` when `engine: aw` is active. These settings **MUST** be silently overridden.
442+
A conforming implementation **MUST NOT** honor attempts to disable `cli-proxy` or set `tools.github.mode: remote` when `engine: aw` is active. These settings **MUST** be overridden. A conforming implementation **MUST** emit a warning to stderr when either override is applied, so that workflow authors can diagnose unexpected configuration behaviour.
443443
444444
### 6.3 Step Extraction Algorithm
445445

0 commit comments

Comments
 (0)