Skip to content

Commit dc18499

Browse files
Copilotpelikhan
andauthored
feat: enable checksum validation by default in install scripts
- Change SKIP_CHECKSUM default from true to false in both install-gh-aw.sh and actions/setup-cli/install.sh - Remove redundant SKIP_CHECKSUM=false in GitHub Actions context block (no longer needed since it's now the default) - Update header comments to reflect checksums are validated by default Agent-Logs-Url: https://github.com/github/gh-aw/sessions/73f24b82-4807-40b8-a61b-c662ee683ab0 Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
1 parent 42f7c8c commit dc18499

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

actions/setup-cli/install.sh

Lines changed: 2 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

install-gh-aw.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ set +o histexpand
55
# Script to download and install gh-aw binary for the current OS and architecture
66
# Supports: Linux, macOS (Darwin), FreeBSD, Windows (Git Bash/MSYS/Cygwin)
77
# If no version is specified, it will use "latest"
8-
# Note: Checksum validation is currently skipped by default (will be enabled in future releases)
8+
# SHA256 checksum validation is performed by default to ensure binary integrity.
99
#
1010
# Usage: ./install.sh [version] [options]
1111
#
@@ -21,15 +21,14 @@ set +o histexpand
2121
set -e # Exit on any error
2222

2323
# Parse arguments
24-
SKIP_CHECKSUM=true # Default to true until checksums are available in releases
24+
SKIP_CHECKSUM=false # Checksum verification is enabled by default
2525
TRY_GH_INSTALL=false # Whether to try gh extension install first
2626
VERSION=""
2727

2828
# Check if INPUT_VERSION is set (GitHub Actions context)
2929
if [ -n "$INPUT_VERSION" ]; then
3030
VERSION="$INPUT_VERSION"
3131
TRY_GH_INSTALL=true # In GitHub Actions, try gh install first
32-
SKIP_CHECKSUM=false # Enable checksum validation in GitHub Actions
3332
fi
3433

3534
for arg in "$@"; do

0 commit comments

Comments
 (0)