Skip to content

Commit 5589885

Browse files
authored
fix(internal/librarian/java): rename expected to want in TestResolveGAPICOptions (#4973)
Rename "expected" to "want" for consistencyy across the repo.
1 parent 456f9e5 commit 5589885

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

internal/librarian/java/generate_test.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@ const googleapisDir = "../../testdata/googleapis"
3737

3838
func TestResolveGAPICOptions(t *testing.T) {
3939
for _, test := range []struct {
40-
name string
41-
cfg *config.Config
42-
library *config.Library
43-
api *config.API
44-
apiCfgs *serviceconfig.API
45-
expected []string
40+
name string
41+
cfg *config.Config
42+
library *config.Library
43+
api *config.API
44+
apiCfgs *serviceconfig.API
45+
want []string
4646
}{
4747
{
4848
name: "basic case",
@@ -52,7 +52,7 @@ func TestResolveGAPICOptions(t *testing.T) {
5252
apiCfgs: &serviceconfig.API{Transports: map[string]serviceconfig.Transport{
5353
config.LanguageJava: serviceconfig.GRPCRest,
5454
}},
55-
expected: []string{
55+
want: []string{
5656
"metadata",
5757
"repo=googleapis/google-cloud-java",
5858
"artifact=com.google.cloud:google-cloud-secretmanager",
@@ -70,7 +70,7 @@ func TestResolveGAPICOptions(t *testing.T) {
7070
apiCfgs: &serviceconfig.API{Transports: map[string]serviceconfig.Transport{
7171
config.LanguageJava: serviceconfig.Rest,
7272
}},
73-
expected: []string{
73+
want: []string{
7474
"metadata",
7575
"repo=googleapis/google-cloud-java",
7676
"artifact=com.google.cloud:google-cloud-secretmanager",
@@ -93,7 +93,7 @@ func TestResolveGAPICOptions(t *testing.T) {
9393
config.LanguageJava: true,
9494
},
9595
},
96-
expected: []string{
96+
want: []string{
9797
"metadata",
9898
"repo=googleapis/google-cloud-java",
9999
"artifact=com.google.cloud:google-cloud-secretmanager",
@@ -108,7 +108,7 @@ func TestResolveGAPICOptions(t *testing.T) {
108108
library: &config.Library{Name: "secretmanager"},
109109
api: &config.API{Path: "google/cloud/secretmanager/v1"},
110110
apiCfgs: &serviceconfig.API{},
111-
expected: []string{
111+
want: []string{
112112
"metadata",
113113
"repo=googleapis/google-cloud-java",
114114
"artifact=com.google.cloud:google-cloud-secretmanager",
@@ -125,7 +125,7 @@ func TestResolveGAPICOptions(t *testing.T) {
125125
if err != nil {
126126
t.Fatal(err)
127127
}
128-
if diff := cmp.Diff(test.expected, got); diff != "" {
128+
if diff := cmp.Diff(test.want, got); diff != "" {
129129
t.Errorf("mismatch (-want +got):\n%s", diff)
130130
}
131131
})

0 commit comments

Comments
 (0)