Merge pull request #3841 from hey-api/pullfrog/3838-fix-duplicate-key-in-transformers

Author: mrlubos

.changeset/purple-jars-design.md

@@ -0,0 +1,5 @@
+---
+"@hey-api/openapi-ts": patch
+---
+
+**plugin(@hey-api/transformers)**: fix: use symbols for `additionalProperties` key variables

packages/openapi-ts/src/plugins/@hey-api/transformers/plugin.ts

@@ -195,16 +195,17 @@ function processSchemaType({
     }
 
     if (schema.additionalProperties && dataExpression) {
+      const key = plugin.symbol('key');
       const entryValueNodes = processSchemaType({
-        dataExpression: $(dataExpression).attr('key').computed(),
+        dataExpression: $(dataExpression).attr(key).computed(),
         plugin,
         schema: schema.additionalProperties,
       });
 
       if (entryValueNodes.length) {
         const properties = Object.keys(schema.properties ?? {});
         nodes.push(
-          $.for($.const('key'))
+          $.for($.const(key))
             .of($('Object').attr('keys').call(dataExpression))
             .$if(
               properties.length,
@@ -214,7 +215,7 @@ function processSchemaType({
                     $.not(
                       $.array(...properties)
                         .attr('includes')
-                        .call('key'),
+                        .call(key),
                     ),
                   ).do(...entryValueNodes),
                 ),

packages/openapi-ts/src/ts-dsl/stmt/for.ts

@@ -42,8 +42,8 @@ class ImplForTsDsl<M extends ForMode = 'for'> extends Mixed {
   override analyze(ctx: AnalysisContext): void {
     ctx.analyze(this._condition);
     ctx.analyze(this._iterableOrUpdate);
-    ctx.analyze(this._variableOrInit);
     ctx.pushScope();
+    ctx.analyze(this._variableOrInit);
     try {
       super.analyze(ctx);
     } finally {