linting: fix missing type assertion checks (forcetypeassert)

    priority.go:50:2: right hand must be only type assertion (forcetypeassert)
        *fq = append(*fq, x.(*prioritizedFrame))
        ^
    priority.go:104:2: type assertion must be checked (forcetypeassert)
        frame := heap.Pop(q.queue).(*prioritizedFrame).frame
        ^
    priority_test.go:66:6: type assertion must be checked (forcetypeassert)
            if frame.(*spdy.DataFrame).StreamId != i {
               ^
    priority_test.go:67:55: type assertion must be checked (forcetypeassert)
                t.Fatalf("Wrong frame\nActual: %d\nExpecting: %d", frame.(*spdy.DataFrame).StreamId, i)
                                                                   ^
    priority_test.go:89:6: type assertion must be checked (forcetypeassert)
            if frame.(*spdy.DataFrame).StreamId != i {
               ^
    priority_test.go:90:55: type assertion must be checked (forcetypeassert)
                t.Fatalf("Wrong frame\nActual: %d\nExpecting: %d", frame.(*spdy.DataFrame).StreamId, i)
                                                                   ^
    spdy_test.go:847:3: right hand must be only type assertion (forcetypeassert)
            netconn, _, _ := w.(http.Hijacker).Hijack()
            ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Author: thaJeztah

priority.go

@@ -47,7 +47,11 @@ func (fq frameQueue) Swap(i, j int) {
 }
 
 func (fq *frameQueue) Push(x interface{}) {
-	*fq = append(*fq, x.(*prioritizedFrame))
+	pf, ok := x.(*prioritizedFrame)
+	if !ok || pf == nil {
+		panic("frameQueue.Push: unexpected value")
+	}
+	*fq = append(*fq, pf)
 }
 
 func (fq *frameQueue) Pop() interface{} {
@@ -101,7 +105,10 @@ func (q *PriorityFrameQueue) Pop() spdy.Frame {
 		}
 		q.c.Wait()
 	}
-	frame := heap.Pop(q.queue).(*prioritizedFrame).frame
+	var frame spdy.Frame
+	if f, ok := heap.Pop(q.queue).(*prioritizedFrame); ok {
+		frame = f.frame
+	}
 	q.c.Signal()
 	return frame
 }

priority_test.go

@@ -62,9 +62,12 @@ func TestPriorityQueueOrdering(t *testing.T) {
 	}
 
 	for i := spdy.StreamId(0); i < 150; i++ {
-		frame := queue.Pop()
-		if frame.(*spdy.DataFrame).StreamId != i {
-			t.Fatalf("Wrong frame\nActual: %d\nExpecting: %d", frame.(*spdy.DataFrame).StreamId, i)
+		var sid spdy.StreamId
+		if frame, ok := queue.Pop().(*spdy.DataFrame); ok {
+			sid = frame.StreamId
+		}
+		if sid != i {
+			t.Fatalf("Wrong frame\nActual: %d\nExpecting: %d", sid, i)
 		}
 	}
 }
@@ -85,9 +88,12 @@ func TestPriorityQueueSync(t *testing.T) {
 
 	wg.Wait()
 	for i := spdy.StreamId(0); i < 150; i++ {
-		frame := queue.Pop()
-		if frame.(*spdy.DataFrame).StreamId != i {
-			t.Fatalf("Wrong frame\nActual: %d\nExpecting: %d", frame.(*spdy.DataFrame).StreamId, i)
+		var sid spdy.StreamId
+		if frame, ok := queue.Pop().(*spdy.DataFrame); ok {
+			sid = frame.StreamId
+		}
+		if sid != i {
+			t.Fatalf("Wrong frame\nActual: %d\nExpecting: %d", sid, i)
 		}
 	}
 }

spdy_test.go

@@ -844,7 +844,14 @@ func TestFramingAfterRemoteConnectionClosed(t *testing.T) {
 
 		w.WriteHeader(http.StatusSwitchingProtocols)
 
-		netconn, _, _ := w.(http.Hijacker).Hijack()
+		hj, ok := w.(http.Hijacker)
+		if !ok {
+			t.Fatal("ResponseWriter should be a http.Hijacker")
+		}
+		netconn, _, err := hj.Hijack()
+		if err != nil {
+			t.Fatal(err)
+		}
 		conn, _ := NewConnection(netconn, true)
 		go conn.Serve(func(s *Stream) {
 			_ = s.SendReply(http.Header{}, false)