Merge branch 'followup-issue641' (#641)

Author: rhysd

Makefile

@@ -49,7 +49,8 @@ cov: coverage.out coverage.html
 
 .linttimestamp: $(TESTS) $(SRCS) $(TOOL) docs/checks.md
 	go vet ./...
-	staticcheck ./...
+	# ./... is not available because ./playground/node_dodules/ contains some Go packages
+	staticcheck ./ ./scripts/... ./cmd/...
 	govulncheck ./...
 ifneq ($(OS),Windows_NT)
 	GOOS=js GOARCH=wasm staticcheck ./playground

cmd/actionlint/main.go

@@ -4,6 +4,8 @@ import (
 	"os"
 
 	"github.com/rhysd/actionlint"
+
+	_ "time/tzdata"
 )
 
 func main() {

parse.go

@@ -393,7 +393,9 @@ func (p *parser) parseScheduleEvent(pos *Pos, n *yaml.Node) *ScheduledEvent {
 					entry.Cron = s
 				}
 			case "timezone":
-				entry.Timezone = p.parseString(e.val, false)
+				if s := p.parseString(e.val, false); s.Value != "" {
+					entry.Timezone = s
+				}
 			default:
 				p.unexpectedKey(e.key, "element of \"schedule\" section", []string{"cron", "timezone"})
 			}

rule_events.go

@@ -81,8 +81,14 @@ func (rule *RuleEvents) checkCron(spec *String) {
 
 // https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#onschedule
 func (rule *RuleEvents) checkTimezone(tz *String) {
-	if _, err := time.LoadLocation(tz.Value); err != nil {
-		rule.Errorf(tz.Pos, "invalid timezone %q in schedule event. It must be a valid IANA timezone name", tz.Value)
+	// `time.LoadLocation` accepts special values "", "UTC", and "Local" but they are not correct IANA timezone names.
+	ok := tz.Value != "" && !strings.EqualFold(tz.Value, "utc") && !strings.EqualFold(tz.Value, "local")
+	if ok {
+		_, err := time.LoadLocation(tz.Value)
+		ok = err == nil
+	}
+	if !ok {
+		rule.Errorf(tz.Pos, "invalid timezone %q in schedule event. it must be a valid IANA timezone name", tz.Value)
 	}
 }
 

scripts/generate-actionlint-matcher/test.mjs

@@ -38,7 +38,7 @@ for (const parent of ['examples', 'err']) {
             if (line.length === 0 || line.startsWith('/')) {
                 continue
             }
-            const msg = `Line '${line}' did not match to the regex`
+            const msg = `Line '${line}' did not match to the regex ${regexp}`
             const m = line.match(regexp);
             assert.ok(m, msg); // not null
             assert.equal('test.yaml', m[pattern.file], msg);

testdata/err/schedule_invalid_timezone.out

@@ -1 +1,5 @@
-test.yaml:4:17: invalid timezone "Not/A/Timezone" in schedule event. It must be a valid IANA timezone name [events]
+test.yaml:4:17: invalid timezone "Not/A/Timezone" in schedule event. it must be a valid IANA timezone name [events]
+test.yaml:6:17: invalid timezone "UTC" in schedule event. it must be a valid IANA timezone name [events]
+test.yaml:8:17: invalid timezone "local" in schedule event. it must be a valid IANA timezone name [events]
+test.yaml:10:17: string should not be empty [syntax-check]
+test.yaml:11:13: string should not be empty [syntax-check]

testdata/err/schedule_invalid_timezone.yaml

@@ -1,10 +1,17 @@
-on:
-  schedule:
-    - cron: '*/5 * * * *'
-      timezone: "Not/A/Timezone"
-
-jobs:
-  test:
-    runs-on: ubuntu-latest
-    steps:
-      - run: echo hello
+on:
+  schedule:
+    - cron: '*/5 * * * *'
+      timezone: 'Not/A/Timezone'
+    - cron: '*/5 * * * *'
+      timezone: 'UTC'
+    - cron: '*/5 * * * *'
+      timezone: 'local'
+    - cron: '*/5 * * * *'
+      timezone: ''
+    - cron: ''
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - run: echo hello