Make -Dwarnings mandatory when running build-and-test

Author: GuillaumeGomez

.github/workflows/linux.yml

@@ -36,4 +36,6 @@ jobs:
         rustup target add ${{ matrix.target }}
 
     - name: Build and Test
+      env:
+        RUSTFLAGS: -D warnings
       run: cargo run --bin ci-integration build-and-test

.github/workflows/mac.yml

@@ -32,4 +32,6 @@ jobs:
         rustup target add ${{ matrix.target }}
 
     - name: Build and Test
+      env:
+        RUSTFLAGS: -D warnings
       run: cargo run --bin ci-integration build-and-test

.github/workflows/windows.yml

@@ -58,4 +58,6 @@ jobs:
       shell: bash
 
     - name: Build and Test
+      env:
+        RUSTFLAGS: -D warnings
       run: cargo run --bin ci-integration build-and-test

ci/build_and_test.rs

@@ -8,7 +8,24 @@ fn run_tests_in_dir(env: &HashMap<&str, &str>, dir: &str) -> Result<(), String>
 }
 
 pub fn runner() -> Result<(), String> {
-    let env = HashMap::from([("RUSTFLAGS", "-D warnings"), ("RUSTFMT_CI", "1")]);
+    let Ok(rustflags) = std::env::var("RUSTFLAGS") else {
+        return Err(
+            "`RUSTFLAGS` environment variable must be set to run `build-and-test`".to_string(),
+        );
+    };
+    if !rustflags.contains("-D warnings") && !rustflags.contains("-Dwarnings") {
+        return Err(
+            "`RUSTFLAGS` environment variable must contain `-Dwarnings` to run `build-and-test`"
+                .to_string(),
+        );
+    }
+
+    let mut env = HashMap::from([("RUSTFLAGS", "-D warnings"), ("RUSTFMT_CI", "1")]);
+    let value_holder;
+    if let Ok(cfg_release_channel) = std::env::var("CFG_RELEASE_CHANNEL") {
+        value_holder = cfg_release_channel;
+        env.insert("CFG_RELEASE_CHANNEL", value_holder.as_str());
+    }
 
     // Print version information
     run_command_with_env("rustc", &["-Vv"], ".", &env)?;