address comments

Author: icecrasher321

apps/sim/app/api/admin/mothership/route.ts

@@ -67,10 +67,6 @@ export const POST = withRouteHandler(async (req: NextRequest) => {
   if (!queryValidation.success) return queryValidation.response
   const { env: environment, endpoint } = queryValidation.data
 
-  if (!endpoint) {
-    return NextResponse.json({ error: 'endpoint query param required' }, { status: 400 })
-  }
-
   if (!isValidEndpoint(endpoint)) {
     return NextResponse.json({ error: 'invalid endpoint' }, { status: 400 })
   }
@@ -126,10 +122,6 @@ export const GET = withRouteHandler(async (req: NextRequest) => {
   if (!queryValidation.success) return queryValidation.response
   const { env: environment, endpoint } = queryValidation.data
 
-  if (!endpoint) {
-    return NextResponse.json({ error: 'endpoint query param required' }, { status: 400 })
-  }
-
   if (!isValidEndpoint(endpoint)) {
     return NextResponse.json({ error: 'invalid endpoint' }, { status: 400 })
   }

apps/sim/app/api/auth/trello/authorize/route.ts

@@ -13,15 +13,15 @@ const logger = createLogger('TrelloAuthorize')
 export const dynamic = 'force-dynamic'
 
 export const GET = withRouteHandler(async (request: NextRequest) => {
-  const parsed = await parseRequest(authorizeTrelloContract, request, {})
-  if (!parsed.success) return parsed.response
-
   try {
     const session = await getSession()
     if (!session?.user?.id) {
       return NextResponse.json({ error: 'Unauthorized' }, { status: 401 })
     }
 
+    const parsed = await parseRequest(authorizeTrelloContract, request, {})
+    if (!parsed.success) return parsed.response
+
     const apiKey = env.TRELLO_API_KEY
 
     if (!apiKey) {

apps/sim/lib/api/contracts/mothership-tasks.ts

@@ -108,7 +108,7 @@ export const adminMothershipQuerySchema = z
       (value) => (value === '' || value === undefined ? 'dev' : value),
       z.string().min(1).default('dev')
     ),
-    endpoint: z.preprocess((value) => (value === '' ? undefined : value), z.string().optional()),
+    endpoint: z.string().min(1, 'endpoint query param required'),
   })
   .passthrough()
 export type AdminMothershipQuery = z.output<typeof adminMothershipQuerySchema>