fix(knowledge): resolve type errors and unhandled rejection in search routes

- Use accessCheck.knowledgeBase.embeddingModel directly in chunks response
- Narrow access-check predicate to KnowledgeBaseAccessResult in v1 search
- Move inaccessible-KB 404 check before query embedding promise creation

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: waleedlatif1

apps/sim/app/api/knowledge/[id]/documents/[documentId]/chunks/route.ts

@@ -245,7 +245,7 @@ export const POST = withRouteHandler(
                       completion: 0,
                       total: newChunk.tokenCount,
                     },
-                    model: chunkEmbeddingModel,
+                    model: accessCheck.knowledgeBase.embeddingModel,
                     pricing: cost.pricing,
                   },
                 }

apps/sim/app/api/knowledge/search/route.ts

@@ -264,10 +264,6 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
       }
       const queryEmbeddingModel = embeddingModels[0]
 
-      const queryEmbeddingPromise = hasQuery
-        ? generateSearchEmbedding(validatedData.query!, queryEmbeddingModel, workspaceId)
-        : Promise.resolve(null)
-
       // Check if any requested knowledge bases were not accessible
       const inaccessibleKbIds = knowledgeBaseIds.filter((id) => !accessibleKbIds.includes(id))
 
@@ -278,6 +274,10 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
         )
       }
 
+      const queryEmbeddingPromise = hasQuery
+        ? generateSearchEmbedding(validatedData.query!, queryEmbeddingModel, workspaceId)
+        : Promise.resolve(null)
+
       if (workflowId) {
         const authorization = await authorizeWorkflowByWorkspacePermission({
           workflowId,

apps/sim/app/api/v1/knowledge/search/route.ts

@@ -14,7 +14,7 @@ import {
   handleVectorOnlySearch,
   type SearchResult,
 } from '@/app/api/knowledge/search/utils'
-import { checkKnowledgeBaseAccess } from '@/app/api/knowledge/utils'
+import { checkKnowledgeBaseAccess, type KnowledgeBaseAccessResult } from '@/app/api/knowledge/utils'
 import {
   authenticateRequest,
   handleError,
@@ -84,13 +84,12 @@ export const POST = withRouteHandler(async (request: NextRequest) => {
     const accessChecks = await Promise.all(
       knowledgeBaseIds.map((kbId) => checkKnowledgeBaseAccess(kbId, userId))
     )
-    const accessibleKbs = knowledgeBaseIds
-      .map((_, idx) => accessChecks[idx])
+    const accessibleKbs = accessChecks
       .filter(
-        (ac): ac is NonNullable<typeof ac> =>
-          Boolean(ac?.hasAccess) && ac?.knowledgeBase?.workspaceId === workspaceId
+        (ac): ac is KnowledgeBaseAccessResult =>
+          ac.hasAccess === true && ac.knowledgeBase.workspaceId === workspaceId
       )
-      .map((ac) => ac.knowledgeBase!)
+      .map((ac) => ac.knowledgeBase)
     const accessibleKbIds = accessibleKbs.map((kb) => kb.id)
 
     if (accessibleKbIds.length === 0) {