Skip to content

Commit fc1d2ff

Browse files
docs(skills): require screenshots or videos for UI-impacting PRs (#9701)
## Description Updates the `review-pr-local` skill so the PR review agent analyzes the PR description and comments for screenshots and videos when the change is UI-impacting. If visual evidence is missing for a user-visible change, the agent should ask for it (e.g. _"For faster review, please upload screenshots or a video of the feature working end to end."_) and treat the review as `Request changes`. This addresses the Slack thread asking the agent itself to request visual evidence on UI-impacting PRs and to make it (effectively) blocking. This is a new version of #9650, rebased on the current master branch. ## Linked Issue - [x] N/A — skill-only change. ## Screenshots / Videos N/A — docs-only change to a skill markdown file. ## Testing Reviewed the rendered markdown locally; no code changes. ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode _Conversation: https://staging.warp.dev/conversation/ab81ec4d-60dc-4d12-a95e-51edfe581e0c_ _Run: https://oz.staging.warp.dev/runs/019de151-a557-712a-ac02-58a8d4fb90ec_ _This PR was generated with [Oz](https://warp.dev/oz)._ Co-authored-by: Oz <oz-agent@warp.dev>
1 parent e75b315 commit fc1d2ff

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

.agents/skills/review-pr-local/SKILL.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,15 @@ skill marks as overridable.
2222
- In WarpUI code, flag inline `MouseStateHandle::default()` usage during render or event handling. Mouse state handles should be created during construction and then cloned/referenced where needed.
2323
- For user-facing UI changes, mention missing validation only when it is tied to a concrete risk or when the PR changes behavior that should be verified visually.
2424

25+
## UI-impacting changes require visual evidence
26+
27+
- If the PR changes anything user-visible (UI components, layout, styling, copy in surfaces users see, terminal/Warp app visuals, or other behavior a user can perceive), analyze both `pr_description.txt` and any PR comments available in the workflow context for attached screenshots, GIFs, or videos demonstrating the change end to end.
28+
- Treat markdown image/video embeds (`![...](...)`, `<img ...>`, `<video ...>`), GitHub user-attachment links (e.g. `https://github.com/user-attachments/...`, `https://github.com/__user-images/...`), Loom links, and similar hosted media as valid evidence.
29+
- The `Screenshots / Videos` section from `.github/pull_request_template.md` being present but empty does not count as evidence.
30+
- If the change is UI-impacting and no screenshots or videos are attached in the description or comments, add an inline or summary-level comment requesting them. Use wording such as: "For faster review, please upload screenshots or a video of the feature working end to end."
31+
- When required visual evidence is missing for a UI-impacting change, set the final recommendation in `summary` to `Request changes`, even if no other blocking issues were found. Call this out explicitly in the `## Verdict` section.
32+
- If the PR is clearly not user-visible (pure refactor, internal tooling, build scripts, server-only logic with no UI surface, tests, docs-only), do not request screenshots or videos.
33+
2534
## User-facing strings
2635

2736
- Flag interpolated text that would read unnaturally at runtime or combine sentence fragments with the wrong casing.

0 commit comments

Comments
 (0)