Skip to content

Commit d1aa9ca

Browse files
authored
Fix tests run on enron (#1789)
* Fix tests run on enron * Default language to englishe in num2words
1 parent 3740c1a commit d1aa9ca

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

giskard/scanner/robustness/text_transformations.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,11 @@ def _load_dictionaries(self):
283283

284284
def make_perturbation(self, row):
285285
# Replace numbers with words
286-
return self._regex.sub(lambda x: num2words(x.group(), lang=row["language__gsk__meta"]), row[self.column])
286+
value = row[self.column]
287+
if pd.isna(value):
288+
return value
289+
lang = row["language__gsk__meta"] if not pd.isna(row["language__gsk__meta"]) else "en"
290+
return self._regex.sub(lambda x: num2words(x.group(), lang=lang), value)
287291

288292

289293
class TextReligionTransformation(TextLanguageBasedTransformation):

giskard/scanner/scanner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ def _run_detectors(self, detectors, model, dataset, features, verbose=True, rais
152152
try:
153153
detected_issues = detector.run(model, dataset, features=features)
154154
except Exception as err:
155-
logger.error(f"Detector {detector.__class__.__name__} failed with error: {err}")
155+
logger.exception(f"Detector {detector.__class__.__name__} failed with error: {err}")
156156
errors.append((detector, err))
157157
analytics.track(
158158
"scan:run-detector:error",

0 commit comments

Comments
 (0)