Skip to content

Fix tests run on enron#1789

Merged
Hartorn merged 2 commits intomainfrom
fix-nightly-tests
Feb 2, 2024
Merged

Fix tests run on enron#1789
Hartorn merged 2 commits intomainfrom
fix-nightly-tests

Conversation

@Hartorn
Copy link
Copy Markdown
Member

@Hartorn Hartorn commented Feb 2, 2024

Description

TextNumberToWordTransformation was failing if row["language__gsk__meta"] was nan

Before : https://github.com/Giskard-AI/giskard/actions/runs/7750039265
After : https://github.com/Giskard-AI/giskard/actions/runs/7753720227

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn self-assigned this Feb 2, 2024
value = row[self.column]
lang = row["language__gsk__meta"]
if pd.isna(value) or pd.isna(lang):
return value
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not pd.isna(value) and pd.isna(lang) I would still apply num2words without specifying lang (it would default to english).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the defaulting to en

@Hartorn Hartorn enabled auto-merge (squash) February 2, 2024 09:30
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 2, 2024

@Hartorn Hartorn merged commit d1aa9ca into main Feb 2, 2024
@Hartorn Hartorn deleted the fix-nightly-tests branch February 2, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants