Feature/gsk 1233 when a test is buggy the whole test suite does not return#1155
Merged
andreybavt merged 22 commits intomainfrom Jun 21, 2023
Conversation
GSK-1233 When a test is buggy, the whole test suite does not return any results
This test below throw an error message: When we add this test to a working test suite, the resulting test suite does not return any output result for ALL the tests (even the working ones). However as shown below the "test suite has been executed successfully" |
…ole-test-suite-does-not-return-2
…ole-test-suite-does-not-return-2
…ole-test-suite-does-not-return-2
…ole-test-suite-does-not-return-2
…ole-test-suite-does-not-return-2 # Conflicts: # frontend/src/views/main/project/TestSuites.vue
andreybavt
suggested changes
Jun 19, 2023
| result)) | ||
| except Exception: | ||
| error = traceback.format_exc() | ||
| logging.error(error) |
Contributor
There was a problem hiding this comment.
why not logging.exception to also pring the stack trace?
| if verbose: | ||
| print("""Executed '{0}' with arguments {1}: {2}""".format(test_partial.test_name, test_params, | ||
| result)) | ||
| except Exception: |
Contributor
There was a problem hiding this comment.
can you add # noqa NOSONAR
to make IDE and Sonar happy?
…ole-test-suite-does-not-return-2 # Conflicts: # frontend/src/views/main/project/SuiteTestExecutionCard.vue # frontend/src/views/main/project/TestSuiteExecutionHeader.vue
andreybavt
suggested changes
Jun 20, 2023
Co-authored-by: Andrey Avtomonov <andreybavt@gmail.com>
Co-authored-by: Andrey Avtomonov <andreybavt@gmail.com>
…ole-test-suite-does-not-return-2
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handle test error when executing test suite
Type of Change