Skip to content

[GSK-1277] Fix redirect errors on Debugger component#1160

Merged
henchaves merged 12 commits intomainfrom
feature/gsk-1277-debugging-session-doesnt-open-automatically-after-being
Jun 12, 2023
Merged

[GSK-1277] Fix redirect errors on Debugger component#1160
henchaves merged 12 commits intomainfrom
feature/gsk-1277-debugging-session-doesnt-open-automatically-after-being

Conversation

@henchaves
Copy link
Copy Markdown
Member

Description

This PR aims to fix all redirects to Debugger when opening/creating a debugging session.

Examples:

  • Debugger tab: when there is no debugging session, creating a new one should open the InspectionWrapper component
  • Debugger tab: when there are debugging sessions, creating a new one should open the InspectionWrapper component
  • Catalog/Models tab: clicking on "DEBUG" button of a specific model should redirect to Debugger tab and open the InspectionWrapper component

Related Issue

GSK-1277 (available on Linear) and GSK-1228 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@linear
Copy link
Copy Markdown

linear Bot commented Jun 8, 2023

GSK-1277 Debugging session doesn't open automatically after being created

image.png

To reproduce:

  • upload model and dataset (titanic for example)
  • create debugging session from the catalog/models page

Copy link
Copy Markdown
Contributor

@andreybavt andreybavt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still unhandled case when you open debugging session and then go back, the there a blank screen instead of debugging sessions list

Comment thread frontend/src/components/AddDebuggingSessionModal.vue Outdated
Comment thread frontend/src/views/main/project/InspectorWrapper.vue Outdated
@henchaves henchaves requested a review from andreybavt June 9, 2023 08:36
@henchaves henchaves self-assigned this Jun 9, 2023
@andreybavt andreybavt requested a review from Googleton June 9, 2023 15:27
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@henchaves henchaves merged commit 6c47c3b into main Jun 12, 2023
@Hartorn Hartorn deleted the feature/gsk-1277-debugging-session-doesnt-open-automatically-after-being branch September 13, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants