Skip to content

[GSK-1236] Add spinner to explanations while its computing#1165

Merged
henchaves merged 5 commits intomainfrom
feature/gsk-1236-add-spinner-to-text-explanation-while-its-computing
Jun 12, 2023
Merged

[GSK-1236] Add spinner to explanations while its computing#1165
henchaves merged 5 commits intomainfrom
feature/gsk-1236-add-spinner-to-text-explanation-while-its-computing

Conversation

@henchaves
Copy link
Copy Markdown
Member

Description

This PR aims to add a spinner to be shown while the explanation is being computed.

Related Issue

GSK-1236 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@linear
Copy link
Copy Markdown

linear Bot commented Jun 9, 2023

GSK-1236 Add spinner to Text explanation while it's computing

There was a vue spinner in v1, it's a regression that it was removed in v2.

CleanShot 2023-06-06 at 18.33.452x.png

@henchaves henchaves requested a review from alexcombessie June 9, 2023 12:52
@henchaves henchaves self-assigned this Jun 9, 2023
@andreybavt andreybavt requested a review from Googleton June 9, 2023 14:35
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@henchaves henchaves merged commit 71cc969 into main Jun 12, 2023
@Hartorn Hartorn deleted the feature/gsk-1236-add-spinner-to-text-explanation-while-its-computing branch September 13, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants