Skip to content

[GSK-1304] Add tests for over- and under-confidence#1173

Merged
andreybavt merged 16 commits intomainfrom
task/GSK-1304
Jun 15, 2023
Merged

[GSK-1304] Add tests for over- and under-confidence#1173
andreybavt merged 16 commits intomainfrom
task/GSK-1304

Conversation

@mattbit
Copy link
Copy Markdown
Member

@mattbit mattbit commented Jun 13, 2023

No description provided.

@linear
Copy link
Copy Markdown

linear Bot commented Jun 13, 2023

@mattbit mattbit marked this pull request as ready for review June 14, 2023 09:47
@mattbit mattbit requested a review from andreybavt June 14, 2023 09:47
Copy link
Copy Markdown
Contributor

@andreybavt andreybavt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, just a few comments

Comment thread python-client/giskard/testing/tests/calibration.py Outdated
Comment thread python-client/giskard/scanner/calibration/underconfidence_detector.py Outdated
Comment thread python-client/giskard/testing/tests/calibration.py Outdated
@andreybavt andreybavt merged commit 1fe952b into main Jun 15, 2023
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.2% 94.2% Coverage
0.0% 0.0% Duplication

@Hartorn Hartorn deleted the task/GSK-1304 branch September 13, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants