Skip to content

[GSK-1275] Importance of metrics calculated on partial data slice#1193

Merged
mattbit merged 11 commits intomainfrom
task/fix-scan-metrics
Jun 21, 2023
Merged

[GSK-1275] Importance of metrics calculated on partial data slice#1193
mattbit merged 11 commits intomainfrom
task/fix-scan-metrics

Conversation

@mattbit
Copy link
Copy Markdown
Member

@mattbit mattbit commented Jun 21, 2023

Same as #1169 but now on main!

@linear
Copy link
Copy Markdown

linear Bot commented Jun 21, 2023

GSK-1275 Importance of metrics calculated on partial data slice

User KD_A on reddit pointed out that

And does the # samples refer to the # samples in the data slice? It should be the denominator of the metric for the slice. For example, if that second row's recall of 0.111 is 1 predicted positive / 9 true positive, it's debatable whether to flag that.

This is right. We may have 1000 samples in our data slice, but to calculate for example the recall we only use the positive samples, which may be just a few samples out of the total, making the detection a false positive.

@mattbit mattbit requested a review from andreybavt June 21, 2023 17:39
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mattbit mattbit merged commit d7047f6 into main Jun 21, 2023
@Hartorn Hartorn deleted the task/fix-scan-metrics branch September 13, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants