[GSK-1365] Make websocket reactive to worker status changes#1236
Merged
[GSK-1365] Make websocket reactive to worker status changes#1236
Conversation
GSK-1365 Make websocket reactive to worker status
This is an improvement of GSK-1199. Currently, the socket is sending the worker status as a polling system. The idea is to only send the status message in two conditions: 1- if status changed from 2- if there is a new subscriber to the websocket channel |
kevinmessiaen
requested changes
Jul 7, 2023
kevinmessiaen
approved these changes
Jul 17, 2023
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This PR aims to migrate the polling system of the ML Worker websocket to only send the current worker status message to the channel if one of the following conditions happens:
Related Issue
GSK-1365 (available on Linear)
Type of Change