Skip to content

Added changelog to clean old tests from catalog#1275

Merged
andreybavt merged 2 commits intomainfrom
feature/gsk-1486-in-catalog-tests-each-test-is-in-2-copies-the-only-diff-is
Aug 7, 2023
Merged

Added changelog to clean old tests from catalog#1275
andreybavt merged 2 commits intomainfrom
feature/gsk-1486-in-catalog-tests-each-test-is-in-2-copies-the-only-diff-is

Conversation

@kevinmessiaen
Copy link
Copy Markdown
Member

Description

Added changelog to clean old tests from catalog.

Giskard tests has been moved from giskard.ml_worker.testing.tests.* to giskard.testing.tests.* and therefore we cannot execute old tests. We later on decided to pickle all giskard tests to avoid the current issue we are facing.

Regarding the duplication of name, this is because the module is different and there aren't seen as unique. We should ensure in the future to better manage migration of tests when changing folder to avoid having to delete execution history.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@linear
Copy link
Copy Markdown

linear Bot commented Aug 1, 2023

GSK-1486 In Catalog > Tests each test is in 2 copies (the only diff is debug: bool = False), when using the one without debug: bool = False it doesn't work (got an error:

'giskard.ml_worker.testing.tests.performance'
KeyError
Traceback (most recent call last):
  File "/home/ronan/.local/lib/python3.10/site-packages/giskard/ml_worker/utils/request_interceptor.py", line 50, in wrapper
    res = await loop.run_in_executor(pool, behavior, request, context)
  File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/ronan/.local/lib/python3.10/site-packages/giskard/ml_worker/server/ml_worker_service.py", line 236, in runAdHocTest
    test: GiskardTest = GiskardTest.download(request.testUuid, self.client, None)
  File "/home/ronan/.local/lib/python3.10/site-packages/giskard/ml_worker/core/savable.py", line 126, in download
    data = cls.load(local_dir, uuid, meta)
  File "/home/ronan/.local/lib/python3.10/site-packages/giskard/ml_worker/testing/registry/giskard_test.py", line 77, in load
    elif hasattr(sys.modules[meta.module], meta.name):
KeyError: 'giskard.ml_worker.testing.tests.performance'

@andreybavt andreybavt merged commit 6ccd1ac into main Aug 7, 2023
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Hartorn Hartorn deleted the feature/gsk-1486-in-catalog-tests-each-test-is-in-2-copies-the-only-diff-is branch September 13, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants