Added changelog to clean old tests from catalog#1275
Merged
andreybavt merged 2 commits intomainfrom Aug 7, 2023
Merged
Conversation
GSK-1486 In Catalog > Tests each test is in 2 copies (the only diff is debug: bool = False), when using the one without debug: bool = False it doesn't work (got an error:
|
…is-in-2-copies-the-only-diff-is
andreybavt
approved these changes
Aug 7, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Added changelog to clean old tests from catalog.
Giskard tests has been moved from
giskard.ml_worker.testing.tests.*togiskard.testing.tests.*and therefore we cannot execute old tests. We later on decided to pickle all giskard tests to avoid the current issue we are facing.Regarding the duplication of name, this is because the module is different and there aren't seen as unique. We should ensure in the future to better manage migration of tests when changing folder to avoid having to delete execution history.
Related Issue
Type of Change