Fixed issue where QueryBasedSliceFunction wasn't working with bytes

[kevinmessiaen]

Description

Fixed issue where QueryBasedSliceFunction wasn't working with bytes

Related Issue

Type of Change

• 📚 Examples / docs / tutorials / dependencies update
• 🔧 Bug fix (non-breaking change which fixes an issue)
• 🥂 Improvement (non-breaking change which improves an existing feature)
• 🚀 New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to change)
• 🔐 Security fix

[linear]

GSK-1375 Cannot use .str.contains with values of inferred dtype 'bytes'.

To reproduce: https://colab.research.google.com/drive/1Yrj6LY8MDX5H6PNPyR9SRAuZmiZ50rLM?usp=sharing

[rabah-khalek]

what do you need .fillna(series) for? what does the decoder do for NaN values?

[rabah-khalek]

Otherwise, I have just tested it, it works.

[kevinmessiaen]

The decode return NaN for any value that are not bytes. So we decode bytes and put the original value for other row that was non bytes.

This case it will also wok for mix of bytes and str:

series = pd.Series(['this is str', b'this is bytes'])

decoded = series.str.decode("utf-8") # return [NaN, 'this is bytes']

final_value = decoded.fillna(series) # return ['this is str', 'this is bytes']

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

60.0% Coverage
0.0% Duplication