Skip to content

[GSK-1495] Fix incorrect prediction label color #1292

Merged
AbSsEnT merged 2 commits intomainfrom
feature/gsk-1495-incorrect-color-of-incorrect-prediction-in-the-inspector
Aug 3, 2023
Merged

[GSK-1495] Fix incorrect prediction label color #1292
AbSsEnT merged 2 commits intomainfrom
feature/gsk-1495-incorrect-color-of-incorrect-prediction-in-the-inspector

Conversation

@henchaves
Copy link
Copy Markdown
Member

Description

This PR fixes the incorrect label color for a prediction when the result is a number (0).

Related Issue

GSK-1495 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@henchaves henchaves requested a review from AbSsEnT August 3, 2023 08:56
@henchaves henchaves self-assigned this Aug 3, 2023
@linear
Copy link
Copy Markdown

linear Bot commented Aug 3, 2023

GSK-1495 Incorrect color of incorrect prediction in the inspector

433020b2-9bf1-4555-a6d7-2187e2c3c725

It should be always like that:

  • Actual label: grey
  • Predicted label if same as actual: green
  • Predicted label if not same: red

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AbSsEnT
Copy link
Copy Markdown
Contributor

AbSsEnT commented Aug 3, 2023

Perfect!

@AbSsEnT AbSsEnT merged commit b9960fc into main Aug 3, 2023
Copy link
Copy Markdown
Contributor

@AbSsEnT AbSsEnT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@Hartorn Hartorn deleted the feature/gsk-1495-incorrect-color-of-incorrect-prediction-in-the-inspector branch September 13, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants