Conversation
GSK-1506 Code snippet for pickled function (and default values) does not work
When I open a pickled function ( It should be: |
…nction-and-default-values-does
…nction-and-default-values-does
…nction-and-default-values-does
…nction-and-default-values-does
…nction-and-default-values-does
…nction-and-default-values-does
kevinmessiaen
requested changes
Aug 28, 2023
| .value() | ||
| .filter(i => i !== 'str'), | ||
| selected.value.name | ||
| .filter(i => i !== 'str') |
Member
There was a problem hiding this comment.
I think that we should ignore any primitives (int, float, 'str, bool, ...).
Member
There was a problem hiding this comment.
Furthermore we also only need to import when the default value is set
Member
Author
There was a problem hiding this comment.
Furthermore we also only need to import when the default value is set
The line 196 creates an array of only required params
…nction-and-default-values-does
kevinmessiaen
approved these changes
Aug 30, 2023
…nction-and-default-values-does
…nction-and-default-values-does
…nction-and-default-values-does
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This PR aims to fix the code snippet displayed for a custom testing function.
Basically, we must provide to user the code to instantiate
GiskardClientand download the testing function.Also, we should provide the code to download a slicing function/transformation function if they are linked to the given testing function.
Related Issue
GSK-1506 (available on Linear)
Type of Change