Conversation
GSK-1540 Make it possible to create a Slicing Function directly from Catalog
Add a option to the list of Slicing Function called: "Create a new slicing function" When clicked, open a Modal. This modal should contain three radio buttons: "Global", "Project", "Dataset"
|
…a-slicing-function-directly-from
…a-slicing-function-directly-from
kevinmessiaen
approved these changes
Aug 16, 2023
…a-slicing-function-directly-from
|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This PR aims to make it possible to create a new slicing function directly from the Catalog tab.
There will be an item on the Slicing Function list called "CREATE NEW SLICING FUNCTION".
Once clicked, it opens a modal with a form. On this form there will be radio buttons with possible scopes for a new slicing function:
There will be two merges for this PR. The first one implements the "Specific dataset" scope, and the second one implements the "General" scope (because it may cause a lot of conflicts with #1175).
Related Issue
GSK-1540 (available on Linear)
Type of Change