[GSK-1576] Make "go back" available with shuffle mode in Dataset Explorer#1329
Merged
andreybavt merged 3 commits intomainfrom Aug 25, 2023
Merged
Conversation
andreybavt
reviewed
Aug 24, 2023
| const percentRegressionUnit = ref(true); | ||
|
|
||
| const canPrevious = computed(() => !shuffleMode.value && rowNb.value > 0); | ||
| const canPrevious = computed(() => rowNb.value > 0); |
Contributor
There was a problem hiding this comment.
how will it work if previous does rowNb.value -= 1; and it'll mean that instead of going to a previous example you saw earlier you'd go to an example with a row number = current - 1?
Member
Author
There was a problem hiding this comment.
@andreybavt it's already doing that, because the data points come from backend already shuffled. To get the exactly previous data point of the original order we could use the property _GISKARD_INDEX_ instead of rowNb
Member
Author
There was a problem hiding this comment.
So, to wrap up, the behaviour of rowNb.value -= 1 (current behaviour) is to go back to the last data point seen instead of the datapoint with _GISKARD_INDEX_ - 1
|
Kudos, SonarCloud Quality Gate passed! |
andreybavt
approved these changes
Aug 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the previous data point available while the shuffle mode is on in the Dataset Explorer (Debugger tab). Previously, it was not able to move back to the previous data point when the shuffle mode was on.
Related Issue
GSK-1576 (available on Linear)