Skip to content

[GSK-1552] Fix test suite not being listed on Testing tab#1333

Merged
henchaves merged 14 commits intomainfrom
feature/gsk-1552-test-suite-isnt-listed-if-it-doesnt-contain-a-name
Aug 30, 2023
Merged

[GSK-1552] Fix test suite not being listed on Testing tab#1333
henchaves merged 14 commits intomainfrom
feature/gsk-1552-test-suite-isnt-listed-if-it-doesnt-contain-a-name

Conversation

@henchaves
Copy link
Copy Markdown
Member

@henchaves henchaves commented Aug 24, 2023

Description

This PR aims to fix the error generated when a Test Suite without a name is uploaded. To solve that, basically we add a default name to Suite python class if there is no name before uploading it.

Related Issue

GSK-1552 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@henchaves henchaves added the Python Pull requests that update Python code label Aug 24, 2023
@henchaves henchaves self-assigned this Aug 24, 2023
@linear
Copy link
Copy Markdown

linear Bot commented Aug 24, 2023

GSK-1552 Test suite isn't listed if it doesn't contain a name

image.png

https://demo.giskard.ai/main/projects/1451/testing

https://demo.giskard.ai/main/projects/1451/testing/6247/overview

kevinmessiaen
kevinmessiaen requested changes Aug 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kevinmessiaen kevinmessiaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should add some check in the backend to throw an error when trying to save a suite with a blank name

kevinmessiaen
kevinmessiaen approved these changes Aug 30, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kevinmessiaen kevinmessiaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread backend/src/main/java/ai/giskard/service/TestSuiteService.java Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@henchaves henchaves merged commit 1ca47fc into main Aug 30, 2023
@Hartorn Hartorn deleted the feature/gsk-1552-test-suite-isnt-listed-if-it-doesnt-contain-a-name branch September 13, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinmessiaen kevinmessiaen kevinmessiaen approved these changes

Assignees

@henchaves henchaves

Labels

Backend Python Pull requests that update Python code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@henchaves @kevinmessiaen