Skip to content

[GSK-1587] Add MixPanel to backend and track WebSocket events with general info#1338

Merged
kevinmessiaen merged 21 commits intomainfrom
websocket-mixpanel-java
Sep 18, 2023
Merged

[GSK-1587] Add MixPanel to backend and track WebSocket events with general info#1338
kevinmessiaen merged 21 commits intomainfrom
websocket-mixpanel-java

Conversation

@Inokinoki
Copy link
Copy Markdown
Member

@Inokinoki Inokinoki commented Aug 28, 2023

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Inokinoki Inokinoki changed the title [GSK-1509] Add MixPanel to backend and track WebSocket events with general info [GSK-1587] Add MixPanel to backend and track WebSocket events with general info Aug 28, 2023
@linear
Copy link
Copy Markdown

linear Bot commented Aug 28, 2023

GSK-1587 MixPanel for Java WebSocket

Create a brand new MixPanel tracking in Java

@Giskard-AI Giskard-AI deleted a comment from linear Bot Aug 28, 2023
kevinmessiaen
kevinmessiaen requested changes Sep 6, 2023
View reviewed changes
Comment thread backend/src/main/java/ai/giskard/service/AnalyticsCollectorService.java Outdated
kevinmessiaen
kevinmessiaen requested changes Sep 15, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@kevinmessiaen kevinmessiaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but we should fix the thread issues

Comment thread backend/src/main/java/ai/giskard/service/AnalyticsCollectorService.java Outdated
Comment thread backend/src/main/java/ai/giskard/service/AnalyticsCollectorService.java
@Inokinoki Inokinoki self-assigned this Sep 15, 2023
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kevinmessiaen kevinmessiaen merged commit 281f614 into main Sep 18, 2023
@kevinmessiaen kevinmessiaen deleted the websocket-mixpanel-java branch September 18, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinmessiaen kevinmessiaen kevinmessiaen approved these changes

@andreybavt andreybavt Awaiting requested review from andreybavt

Assignees

@Inokinoki Inokinoki

Labels

Backend safe for build

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Inokinoki @kevinmessiaen @andreybavt