[GSK-1698] Remove legacy ML worker info and properties#1390
Merged
Conversation
Format `cli_server.py` by git pre-commit
GSK-1698 Adapt `giskard server expose` to the single exposed port
Previously we had to expose 2 ports: HTTP and TCP for worker connection Now that workers connect through the same port as the UI we should adapt the |
andreybavt
suggested changes
Sep 15, 2023
Contributor
There was a problem hiding this comment.
@Inokinoki I see there are still places that mention ports 40051 and 50051 remaining. Could you clean them up completely to avoid confusion?
You can use this to search for remaining cases from the root of giskard repo:
grep "(ml.?)?worker.?(port|host)|40051|50051" * -riE|
Kudos, SonarCloud Quality Gate passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Related Issue
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.make codestyle.