Skip to content

Trying different workflows#1396

Merged
andreybavt merged 1 commit intomainfrom
feature/bazire/improve-build
Sep 15, 2023
Merged

Trying different workflows#1396
andreybavt merged 1 commit intomainfrom
feature/bazire/improve-build

Conversation

@Hartorn
Copy link
Copy Markdown
Member

@Hartorn Hartorn commented Sep 11, 2023

No description provided.

@Hartorn Hartorn force-pushed the feature/bazire/improve-build branch 10 times, most recently from 72c290f to 94c33bb Compare September 12, 2023 17:40
@Hartorn Hartorn marked this pull request as ready for review September 12, 2023 17:40
@Hartorn Hartorn requested a review from andreybavt September 12, 2023 17:40
@Hartorn Hartorn self-assigned this Sep 12, 2023
@Hartorn Hartorn changed the base branch from feature/gsk-1618-run-python-tests-on-windows-builder to main September 12, 2023 18:22
@Hartorn Hartorn requested a review from a team September 12, 2023 18:22
@Hartorn Hartorn changed the base branch from main to feature/gsk-1618-run-python-tests-on-windows-builder September 12, 2023 18:24
@Hartorn Hartorn changed the base branch from feature/gsk-1618-run-python-tests-on-windows-builder to main September 12, 2023 18:24
@Hartorn Hartorn force-pushed the feature/bazire/improve-build branch from 94c33bb to 45316dd Compare September 12, 2023 18:24
andreybavt
andreybavt reviewed Sep 14, 2023
View reviewed changes
Comment thread .github/workflows/build_backend.yml Outdated
Comment thread .github/workflows/build_backend.yml Outdated
@Hartorn Hartorn force-pushed the feature/bazire/improve-build branch 4 times, most recently from 0760e63 to f955229 Compare September 15, 2023 12:24
@andreybavt
Copy link
Copy Markdown
Contributor

andreybavt commented Sep 15, 2023 •
edited
Loading

I think if tests pass and integ is renamed to integration in various places it should be fine to merge

@Hartorn Hartorn force-pushed the feature/bazire/improve-build branch from f955229 to e750b73 Compare September 15, 2023 14:01
@Hartorn Hartorn force-pushed the feature/bazire/improve-build branch from e750b73 to 1485e8e Compare September 15, 2023 14:28
@Hartorn
Copy link
Copy Markdown
Member Author

Hartorn commented Sep 15, 2023

I think if tests pass and integ is renamed to integration in various places it should be fine to merge

Was sure I did it, I must have not pushed it before.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Hartorn
Copy link
Copy Markdown
Member Author

Hartorn commented Sep 15, 2023

@andreybavt Should be all good now

@andreybavt andreybavt merged commit 1f8fb76 into main Sep 15, 2023
@andreybavt andreybavt deleted the feature/bazire/improve-build branch September 15, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andreybavt andreybavt andreybavt left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Hartorn Hartorn

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hartorn @andreybavt