Skip to content

removed unnecessary model validations upon upload#1417

Merged
rabah-khalek merged 3 commits intomainfrom
model_validation
Sep 27, 2023
Merged

removed unnecessary model validations upon upload#1417
rabah-khalek merged 3 commits intomainfrom
model_validation

Conversation

@rabah-khalek
Copy link
Copy Markdown
Contributor

@rabah-khalek rabah-khalek commented Sep 22, 2023

No description provided.

AbSsEnT
AbSsEnT approved these changes Sep 22, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@AbSsEnT AbSsEnT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see only 1 message, that model was validated. This is the right behaviour. Thanks!

@Inokinoki
Copy link
Copy Markdown
Member

Inokinoki commented Sep 22, 2023

Seems the following two tests are broken:

tests/test_upload.py::test_upload_models_exceptions[german_credit_data-german_credit_model] 
[gw1] [ 50%] FAILED tests/test_upload.py::test_upload_models_exceptions[german_credit_data-german_credit_model] 
tests/integrations/test_wandb.py::test_fast[hotel_text_data-hotel_text_model] 
[gw1] [ 50%] FAILED tests/test_upload.py::test_upload_models_exceptions[diabetes_dataset-linear_regression_diabetes]

due to model validation

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rabah-khalek rabah-khalek merged commit ae88afe into main Sep 27, 2023
@rabah-khalek rabah-khalek deleted the model_validation branch September 27, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hartorn Hartorn Hartorn approved these changes

+1 more reviewer

@AbSsEnT AbSsEnT AbSsEnT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rabah-khalek @Inokinoki @Hartorn @AbSsEnT