Skip to content

Little improvements#1479

Merged
Hartorn merged 7 commits intomainfrom
little-improvements
Oct 16, 2023
Merged

Little improvements#1479
Hartorn merged 7 commits intomainfrom
little-improvements

Conversation

@Hartorn
Copy link
Copy Markdown
Member

@Hartorn Hartorn commented Oct 13, 2023

Description

Some several small fixes, on logs, sonar issues and so on

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn self-assigned this Oct 13, 2023
@Hartorn Hartorn force-pushed the little-improvements branch 2 times, most recently from 42e4f95 to e46ffd5 Compare October 13, 2023 14:06
@Hartorn Hartorn force-pushed the little-improvements branch from e46ffd5 to 5c9ff61 Compare October 13, 2023 14:19
@mattbit mattbit self-requested a review October 13, 2023 14:50
@mattbit
Copy link
Copy Markdown
Member

mattbit commented Oct 13, 2023

sorry, just realized that this was still a draft

@Hartorn Hartorn marked this pull request as ready for review October 16, 2023 11:53
@Hartorn
Copy link
Copy Markdown
Member Author

Hartorn commented Oct 16, 2023

sorry, just realized that this was still a draft

No worries. Do you want to re-check or can I merge ?

mattbit
mattbit approved these changes Oct 16, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mattbit mattbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me, just a commend about the deep copy of df but not blocking.

Comment thread giskard/models/model_explanation.py Outdated
@Hartorn Hartorn force-pushed the little-improvements branch from cc42dbd to f51b935 Compare October 16, 2023 15:27
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Hartorn Hartorn merged commit 4a1e2da into main Oct 16, 2023
@Hartorn Hartorn deleted the little-improvements branch October 16, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattbit mattbit mattbit approved these changes

@andreybavt andreybavt Awaiting requested review from andreybavt

@rabah-khalek rabah-khalek Awaiting requested review from rabah-khalek

Assignees

@Hartorn Hartorn

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Hartorn @mattbit