GSK-2426 only run core.core.CallableMeta.extract_doc when necessary#1776
Merged
kevinmessiaen merged 7 commits intomainfrom Feb 20, 2024
Merged
GSK-2426 only run core.core.CallableMeta.extract_doc when necessary#1776kevinmessiaen merged 7 commits intomainfrom
core.core.CallableMeta.extract_doc when necessary#1776kevinmessiaen merged 7 commits intomainfrom
Conversation
… is collecting the catalog i...
Inokinoki
approved these changes
Feb 19, 2024
Member
Inokinoki
left a comment
There was a problem hiding this comment.
LGTM, tested locally:
>>> from giskard.testing.tests.llm import test_llm_char_injection
>>> test_llm_char_injection.meta
<giskard.core.core.TestFunctionMeta object at 0x15cdf6f80>
>>> test_llm_char_injection.meta.doc
2024-02-19 12:20:22,387 pid:14093 MainThread giskard.core.core WARNING Unexpected documentation element for test_llm_char_injection: DocstringSectionKind.admonition
<giskard.core.core.CallableDocumentation object at 0x100d3fe80>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Made
docattribute ofCallableMetaa cached property so that it is only initialised when accessing the value (ei. uploading meta to the Hub)Related Issue
Type of Change