Switching from mlWorkerId to kernel name#1777
Conversation
…feature/gsk-2722-making-the-kernel-actually-start-worker
…l-actually-start-worker
…l-actually-start-worker
…feature/gsk-2722-making-the-kernel-actually-start-worker
|
There was a problem hiding this comment.
Not sure if I'm doing something wrong but I got this error:
GiskardError: Not Found: Python kernel not found by key: No Kernel found with name external_worker
I ran this piece of code:
from giskard import GiskardClient
url = "http://localhost:9000"
api_key = "gsk-..."
# Create a giskard client to communicate with Giskard
client = GiskardClient(url, api_key)
client.create_project('test', 'test', 'external_worker', 'Empty desc')and the worker have external_worker as kernel name:
| The project created in giskard | ||
|
|
||
| """ | ||
| # TODO(Bazire): handle properly the "auto" detection/creation of kernel |
There was a problem hiding this comment.
👍
I really think that we need an auto detection and creation of kernel for ease of use.
There was a problem hiding this comment.
Do you think that we can create/use the kernel with the project id as name?
There was a problem hiding this comment.
Yes either by a project id or some name generated like: {os_host}-{python_version}
If we find another kernel using the same name with different dependencies we just do {os_host}-{python_version}-{random-value}
There was a problem hiding this comment.
| The project created in giskard | ||
|
|
||
| """ | ||
| # TODO(Bazire): handle properly the "auto" detection/creation of kernel |
There was a problem hiding this comment.
Do you think that we can create/use the kernel with the project id as name?
Description
Related Issue
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.make codestyle.