Skip to content

GSK-1993 Updated usage of enum value to enum name#1793

Merged
kevinmessiaen merged 11 commits intomainfrom
GSK-1993
Feb 22, 2024
Merged

GSK-1993 Updated usage of enum value to enum name#1793
kevinmessiaen merged 11 commits intomainfrom
GSK-1993

Conversation

@kevinmessiaen
Copy link
Copy Markdown
Member

Description

Use enum name instead of values for serialization

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@linear
Copy link
Copy Markdown

linear Bot commented Feb 5, 2024

@Hartorn
Copy link
Copy Markdown
Member

Hartorn commented Feb 5, 2024

@kevinmessiaen Maybe we should change the enums type to (str, Enum) also ?
This may allow more easy comparison

@kevinmessiaen kevinmessiaen marked this pull request as ready for review February 19, 2024 02:25
@Inokinoki Inokinoki self-requested a review February 19, 2024 16:54
@sonarqubecloud
Copy link
Copy Markdown

@kevinmessiaen kevinmessiaen merged commit 885011a into main Feb 22, 2024
@kevinmessiaen kevinmessiaen deleted the GSK-1993 branch February 22, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants