Skip to content

[GSK-2807] Documentation polishing#1798

Merged
Hartorn merged 8 commits intomainfrom
feature/gsk-2807-documentation-polishing
Feb 13, 2024
Merged

[GSK-2807] Documentation polishing#1798
Hartorn merged 8 commits intomainfrom
feature/gsk-2807-documentation-polishing

Conversation

@AbSsEnT
Copy link
Copy Markdown
Contributor

@AbSsEnT AbSsEnT commented Feb 9, 2024

Description

GSK-2806
GSK-2707
GSK-2767

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@AbSsEnT AbSsEnT added the documentation Improvements or additions to documentation label Feb 9, 2024
@AbSsEnT AbSsEnT self-assigned this Feb 9, 2024
@linear
Copy link
Copy Markdown

linear Bot commented Feb 9, 2024

Comment thread docs/knowledge/llm_vulnerabilities/index.rst
Comment thread docs/knowledge/llm_scan/index.rst Outdated
@@ -0,0 +1,151 @@
How does the LLM Scan work?
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesnt need to be a different page

Copy link
Copy Markdown
Contributor Author

@AbSsEnT AbSsEnT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luca-martial the contents was returned to its original place.

Comment thread docs/knowledge/llm_vulnerabilities/index.rst
Copy link
Copy Markdown
Contributor

@luca-martial luca-martial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok looks good now - ill let @rabah-khalek review the rest since you addressed 3 different linear cards in 1 PR (better to separate next time)

@AbSsEnT
Copy link
Copy Markdown
Contributor Author

AbSsEnT commented Feb 12, 2024

@luca-martial yes, makes sense to me to separate in the future. However, since there were a lot of small issues dedicated to the same goal of the documentation polishing, I decided to submit everything at once. But yes, separation is good)

@Hartorn
Copy link
Copy Markdown
Member

Hartorn commented Feb 13, 2024

@luca-martial @rabah-khalek Can we merge this, or are we expecting changes ?

@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Feb 13, 2024
@github-actions github-actions Bot removed the Lockfile Temporary label to update pdm.lock label Feb 13, 2024
@Hartorn Hartorn enabled auto-merge (squash) February 13, 2024 11:06
@Hartorn Hartorn disabled auto-merge February 13, 2024 11:06
@Hartorn Hartorn changed the title Feature/gsk 2807 documentation polishing [GSK-2807] Documentation polishing Feb 13, 2024
@Hartorn
Copy link
Copy Markdown
Member

Hartorn commented Feb 13, 2024

@AbSsEnT Btw, never redo the lockfile yourself, especially on MacOS : it's breaking the dependencies on Windows and other stuff. Either use label Lockfile on a PR, run the workflow on a branch, or use the pdm provided command running in docker ;)

@Hartorn Hartorn enabled auto-merge (squash) February 13, 2024 11:08
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Hartorn Hartorn merged commit a2ae079 into main Feb 13, 2024
@Hartorn Hartorn deleted the feature/gsk-2807-documentation-polishing branch February 13, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Development

Successfully merging this pull request may close these issues.

4 participants