Merged
Conversation
mattbit
approved these changes
Mar 21, 2024
|
Hartorn
reviewed
Mar 25, 2024
Member
Hartorn
left a comment
There was a problem hiding this comment.
Overall solid PR, but too much repeated used of string key in dict.
This could be improved by using dataclass/constant/formatting function
Comment on lines
+23
to
+29
| topics = [question["metadata"]["topic"] for question in question_evaluation] | ||
| failure_palette = ["#ba0e0e", "#0a980a"] | ||
| questions = [question["question"] for question in question_evaluation] | ||
| agent_answer = [question["agent_answer"] for question in question_evaluation] | ||
| reference_answer = [question["reference_answer"] for question in question_evaluation] | ||
| correctness = [question["correctness"] for question in question_evaluation] | ||
| colors = [failure_palette[question["correctness"]] for question in question_evaluation] |
Member
There was a problem hiding this comment.
Lots of string defined here, aren't we missing constants here ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.